Bug 165322 - FILEOPEN DOCX Overlapping tracked formatting+deletion displayed incorrectly
Summary: FILEOPEN DOCX Overlapping tracked formatting+deletion displayed incorrectly
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:25.8.0
Keywords:
: 165340 (view as bug list)
Depends on:
Blocks: DOCX-Track-Changes
  Show dependency treegraph
 
Reported: 2025-02-18 19:46 UTC by Gabor Kelemen (allotropia)
Modified: 2025-02-25 11:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word 2016 (13.18 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2025-02-18 19:46 UTC, Gabor Kelemen (allotropia)
Details
The example file in Word and Writer master (112.63 KB, image/png)
2025-02-18 19:46 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2025-02-18 19:46:33 UTC
Created attachment 199291 [details]
Example file from Word 2016

Attached example file shows a change tracked deletion and a style change applied to its first paragraph.

When the file is opened in Writer, the formatted paragraph appears as not deleted, when tracked changes are shown, but correctly hidden when they are hidden.

1. Open attached file
2. Make sure Edit - Track Changes - Show is enabled
-> The "Nunc viverra" sentence is visible as not crossed, but it should be crossed out

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41ab24cecd6ad74312843f113d2faa13259cdb7d
CPU threads: 14; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Looks like this since 4.3 when the formatting change was first imported.

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=ae7f8bed4bc4d7490a158c14d077c5323bd50466..7a6ca9e81c71786b267fde8328c84bb10966c27c

most likely from this range is 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e52f14efaa53b496599b51fb064a933183731fca

Export redline 'paragraph formatting changes' back to DOCX
Comment 1 Gabor Kelemen (allotropia) 2025-02-18 19:46:51 UTC
Created attachment 199292 [details]
The example file in Word and Writer master
Comment 2 Commit Notification 2025-02-25 09:52:27 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c5f7619d6eebe478332ae4dcb27fde85df6278a9

tdf#165322 sw: GetRedline() binary search doesn't work with overlaps

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2025-02-25 09:52:29 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f439448d21ef2feb03a9920d95d30f23795db6ac

tdf#165322 sw: prefer insert/delete redline in mouse-over tooltip

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2025-02-25 10:40:23 UTC
*** Bug 165340 has been marked as a duplicate of this bug. ***
Comment 5 Commit Notification 2025-02-25 11:54:42 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b3567d7e1f08df7c050d3cec86cbb200af558172

tdf#165322 sw: apply formatting for multiple redlines in SwRedlineItr

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.