Bug 165678 - Handle Duplicates: when the dialog opens, all checkboxes should not be marked
Summary: Handle Duplicates: when the dialog opens, all checkboxes should not be marked
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
25.8.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-10 21:27 UTC by Rafael Lima
Modified: 2025-03-18 04:05 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sample ODS file (31.95 KB, application/vnd.oasis.opendocument.spreadsheet)
2025-03-10 21:27 UTC, Rafael Lima
Details
Video showing the proposed change (156.38 KB, video/webm)
2025-03-12 12:55 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2025-03-10 21:27:15 UTC
Created attachment 199723 [details]
Sample ODS file

Currently, when you select a data table and open the Handle Duplicates dialog, the check-boxes of all columns are checked by default. This is troublesome when the table has many columns and you just want to use one (or a few) of them.

I propose we leave them all unchecked by default, because there already exists an "All" button that easily selects all check-boxes. However there's no way to uncheck all of them.

Steps to reproduce: suppose you want to use column B to select duplicate records
1) Open the attached file
2) Select the entire table
3) Go to Data - Duplicates
4) Notice that all columns are selected
5) To select only column B, the user has to manually uncheck all of the others;

Expected result:
All columns should be unchecked by default

System info

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8c74df27aad015eec75c24306904c8c73f3ab4f5
CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: kf6 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 m_a_riosv 2025-03-11 03:48:10 UTC
I think the behavior should be the same as in Autofilter, clicking on 'All' select/deselect all, alternatively.
Comment 2 Rafael Lima 2025-03-11 10:57:50 UTC
(In reply to m_a_riosv from comment #1)
> I think the behavior should be the same as in Autofilter, clicking on 'All'
> select/deselect all, alternatively.

+1 Agreed
Comment 3 Rafael Lima 2025-03-11 13:55:45 UTC
Proposed patch here:
https://gerrit.libreoffice.org/c/core/+/182779

With this patch, the "All" checkbox now works as in the AutoFilter. Clicking it will toggle All/No items selected.
Comment 4 m_a_riosv 2025-03-12 12:30:40 UTC
But it doesn't seem to work the same way as in AutoFilter.
The elements are grayed out, but not unchecked.
Comment 5 Rafael Lima 2025-03-12 12:55:49 UTC
Created attachment 199761 [details]
Video showing the proposed change

(In reply to m_a_riosv from comment #4)
> But it doesn't seem to work the same way as in AutoFilter.
> The elements are grayed out, but not unchecked.

Here's a video of how it is working after applying the proposed patch. For me, there's nothing greyed out.

What OS / VCL are you on?
Comment 6 m_a_riosv 2025-03-12 21:33:34 UTC
Sorry, my mistake, it seems that it is not yet at

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bff3d755c8c11721054f4ff40a3d5f723b0c6b96
CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-GB
Calc: CL threaded
Comment 7 Rafael Lima 2025-03-12 23:54:52 UTC
(In reply to m_a_riosv from comment #6)
> Sorry, my mistake, it seems that it is not yet at

It hasn't been submitted yet. The patch is under review.
Comment 8 Commit Notification 2025-03-18 04:05:10 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e1c7923596f39bac8ce926b56a2450911ffde4d8

tdf#165678 Handle Duplicates dialog: make "All" checkbox work as in AutoFilter

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.