Bug 165827 - Undo label shows "Replace $1 $2 $3" after "Convert Field to Text"
Summary: Undo label shows "Replace $1 $2 $3" after "Convert Field to Text"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Oliver Specht (CIB)
URL:
Whiteboard: target:25.8.0
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2025-03-19 19:00 UTC by Gabor Kelemen (allotropia)
Modified: 2025-03-21 09:07 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Edit -> Undo after Convert Field to Text command (21.55 KB, image/png)
2025-03-19 19:00 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2025-03-19 19:00:20 UTC
Created attachment 199908 [details]
Edit -> Undo after Convert Field to Text command

This is a followup to bug 45946

1. In Writer click Insert - Field - Time (variable)
2. Right click on the field and choose "Convert Field to Text"
3. Open the Edit menu
-> "Undo: Replace $1 $2 $3" is visible

This should not contain un-replaced variables.

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4957d832c76598e78a57324dad5b4de7345a33e2
CPU threads: 14; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded
Comment 1 Commit Notification 2025-03-21 08:36:35 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ec8ea016002e2521649e435fc28850ef3f8e5348

tdf#165827 Assign id to ConvertFieldToText undo action

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.