Bug 165838 - Impress Remove effect animation button text is not visible
Summary: Impress Remove effect animation button text is not visible
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.9.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Animation Dark-Mode
  Show dependency treegraph
 
Reported: 2025-03-20 18:01 UTC by Mihai Vasiliu
Modified: 2025-03-22 11:54 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Effects buttons show different font colors (5.90 KB, image/png)
2025-03-20 18:02 UTC, Mihai Vasiliu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Vasiliu 2025-03-20 18:01:50 UTC
Description:
The '-' symbol on the Remove effect animation button is not visible when using any Dark mode theme.

Steps to Reproduce:
1. Set the LO Appearance theme to any dark theme (Automatic, Office 2003 Blue) and choose Dark option. (Restart if needed)
2. Open Impress and create a new presentation
3. Add any shape
4. Open Animation pane
5. Click on the shape
6. Click on the "+Add" button
7. Look at the button next to it, the Remove animation button with the '-' label.

Actual Results:
The label is black text on black and not visible

Expected Results:
The '-' symbol should be white as well as it is the "+Add".
See the attached image.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.2.1.2 (X86_64) / LibreOffice Community
Build ID: d3abf4aee5fd705e4a92bba33a32f40bc4e56f49
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 26100); UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: CL threaded
Comment 1 Mihai Vasiliu 2025-03-20 18:02:42 UTC
Created attachment 199920 [details]
Effects buttons show different font colors
Comment 2 Brandon H. 2025-03-20 22:44:49 UTC
I am able to reproduce the outcome described. However, I am unsure as to whether or not this would be considered a bug so I will leave this as unconfirmed.

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7b9e27da2033192c628b23e4e1686209e951dadb
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Mihai Vasiliu 2025-03-21 15:46:19 UTC
(In reply to Brandon H. from comment #2)
> I am able to reproduce the outcome described. However, I am unsure as to
> whether or not this would be considered a bug so I will leave this as
> unconfirmed.
> 
> Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 7b9e27da2033192c628b23e4e1686209e951dadb
> CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded

It is an UI/UX bug, so it is a bug nevertheless. :)
Comment 4 raal 2025-03-21 17:27:53 UTC
Confirm with Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ddaea18557b1ec60d9e360f9eab539c8f551061f
CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 5 V Stuart Foote 2025-03-22 11:36:22 UTC
Confirmed. Predates the Appearance theme framework. But noticeable in Dark mode so ~ 7.5.

The 'Minus' fg for the welded button receives the same color as bg when an Animation is selected active. Otherwise when static (selected shape *not* assigned an animation) the button image on the widget matches the adjacent Add, Move up or Move down buttons.

Seems like the implementation of the Sidebar Animation deck for the Animation listbox and the Effects listing (for bug 87813 at 5.2 release) did not fully handle the button for the Remove effect (welded as mxPBRemoveEffect) *when* an animation has been assigned. 

And it differs from the Add effect, or rendering of the Move up and Move down where the button activation is being adjusted when multiple shapes have been assigned animations. 

GTK layout resides .UI at 
https://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/ui/customanimationspanel.ui?r=7e378516bc596d0308bcb1c974760c224f516ea6#254

But the button mode renderings are under control of CustomAnimationPane.cxx/.hxx