Bug 166319 - Interdependent change tracking improvements
Summary: Interdependent change tracking improvements
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:25.8.0
Keywords:
Depends on:
Blocks: DOCX-Track-Changes
  Show dependency treegraph
 
Reported: 2025-04-24 07:42 UTC by Miklos Vajna
Modified: 2025-04-29 10:49 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Minimal reproducer (13.93 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2025-04-24 07:42 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miklos Vajna 2025-04-24 07:42:18 UTC
Created attachment 200490 [details]
Minimal reproducer

There are multiple problems when we have redlines on top of each other (as far as the user is concerned), but one specific use-case as a start:

1) Open the attached document, which contains a larger insert, then a smaller delete inside that

2) Go to the middle of the first "insert only" range, press reject

3) Observe that the entire change was rejected, good

4) Undo

5) Reject again

Expected result: the entire change gets rejected again

Actual result: only the first insert gets rejected
Comment 1 Commit Notification 2025-04-28 07:42:35 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/096a40b27d07603880bbf120440ac169a87fe115

tdf#166319 sw interdependent redlines: fix undo of del on top of ins

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2025-04-29 10:49:53 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ca7a6a57ad1e8d7aadffbbf3fe28d9aabed31286

tdf#166319 sw interdependent redlines: handle format on top of insert

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.