Bug 166402 - With Tools > Optiions > View Icon size changes, NB & Sidebar should resize for correct padding
Summary: With Tools > Optiions > View Icon size changes, NB & Sidebar should resize fo...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Notebookbar Sidebar-UI-UX
  Show dependency treegraph
 
Reported: 2025-04-30 09:32 UTC by Eyal Rozenberg
Modified: 2025-05-02 07:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Notebookbar-tabbed with small icons, LO 25.8 nightly, GTK3 (43.18 KB, image/png)
2025-04-30 09:33 UTC, Eyal Rozenberg
Details
Notebookbar-tabbed with large icons, LO 25.8 nightly, GTK3 (49.97 KB, image/png)
2025-04-30 09:33 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2025-04-30 09:32:58 UTC
When choosing large buttons for the notebookbar (tabbed, and also groupbar compact), its vertical size is nout enough to contain those buttons: There are 0 pixels of space between the edges of top and bottom row buttons, as can be observed when they are in the pressed state; and the bottom row's bottom is actually cut off slightly by the bottom end of the tab bar.

Even if vertical spacing is not variable / user configurable, it should at least increase a bit to accommodate large buttons.
Comment 1 Eyal Rozenberg 2025-04-30 09:33:26 UTC
Created attachment 200613 [details]
Notebookbar-tabbed with small icons, LO 25.8 nightly, GTK3
Comment 2 Eyal Rozenberg 2025-04-30 09:33:41 UTC
Created attachment 200614 [details]
Notebookbar-tabbed with large icons, LO 25.8 nightly, GTK3
Comment 3 V Stuart Foote 2025-04-30 11:27:37 UTC
Confirmed. 

But issue is not with calculating the padding around the icon/label mix when using Tools -> Options -> View (or future Appearance panel) to pick the Notebookbar 'Icon size' (Automatic|Large|Small)

Rather the correct padding is calculated but does not apply until user makes some change to the LO app frame. Otherwise the Icons and labels are changed and resized immediately, just not the padding, leaving them cramped.

With a detected change in size for the app frame (drag is wider, narrower, or resize from a corner) point the correctly sized padding is rendered.

And it manifests the opposite direction, going from the Large icons to the Small icons. On change to the small size, the padding is left too great. Likewise snapping to correctly calculated size with app frame resize.

So, a change made to the 'Icon size' selection should probably trigger the recalculation of layout--not wait for a resize of the app frame to trigger.

Can't see a UX issue why we would not recalculate the Notebookbar layout when the 'Icon size' is changed.

=-testing-=

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e4fb32ffef1630ceaf5a0a77307e02ae93c9f8f4
CPU threads: 28; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 4 V Stuart Foote 2025-04-30 12:17:54 UTC
And, it also manifests with 'Icon size' selection for the Sidebar. Padding is not recalculated/applied when icon set is changed. Resize with correct padding only triggered upon a change to app frame.
Comment 5 Eyal Rozenberg 2025-04-30 12:24:49 UTC
Trying to shorten the title... thanks for the extensive investigation.
Comment 6 Heiko Tietze 2025-05-02 07:17:07 UTC Comment hidden (no-value)