Description: The help page for the VALUE function does not open from Functions in the sidebar. Steps to Reproduce: 1. Open new Calc 2. Show side-bar. 3. Push Functions Icon. 4. Search "VALUE" and select "VALUE" 5. Push Help button. Actual Results: 6. Open Help, but title is "Could not find Help page (404)." https://help.libreoffice.org/25.8/en-US/text/shared/05/err_html.html?System=WIN&DbPAR=CALC&HID=SC_HID_FUNC_WERT Expected Results: 6. Open Help page of VALUE. https://help.libreoffice.org/25.8/en-US/text/scalc/01/func_value.html?DbPAR=CALC#bm_id831542233029549 Reproducible: Always User Profile Reset: No Additional Info: Reproducible with Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f98d81f008e11fd2786597d82126a6287353c714 CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: en-US (ja_JP); UI: en-US Calc: CL threaded
Reproducible Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f98d81f008e11fd2786597d82126a6287353c714 CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-GB Calc: CL threaded
I found 2 ways to fix this: 1) diff --git a/source/text/scalc/01/func_value.xhp b/source/text/scalc/01/func_value.xhp index 03ac5f4701..c1885715d3 100644 --- a/source/text/scalc/01/func_value.xhp +++ b/source/text/scalc/01/func_value.xhp @@ -17,7 +17,7 @@ </meta> <body> <section id="func_value"> - <bookmark id="bm_id61542230672099" xml-lang="en-US" branch="hid/SC_HID_FUNC_VALUE" localize="false"/> + <bookmark id="bm_id61542230672099" xml-lang="en-US" branch="hid/SC_HID_FUNC_WERT" localize="false"/> <bookmark xml-lang="en-US" branch="index" id="bm_id831542233029549"> <bookmark_value>VALUE function</bookmark_value> <bookmark_value>text functions;convert text to numeric value</bookmark_value> or 2) diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h index 8aaf758181ef..48794f18f22e 100644 --- a/sc/inc/helpids.h +++ b/sc/inc/helpids.h @@ -470,7 +470,7 @@ inline constexpr OUString HID_FUNC_GLAETTEN = u"SC_HID_FUNC_GLAETTEN"_ustr; inline constexpr OUString HID_FUNC_GROSS2 = u"SC_HID_FUNC_GROSS2"_ustr; inline constexpr OUString HID_FUNC_GROSS = u"SC_HID_FUNC_GROSS"_ustr; inline constexpr OUString HID_FUNC_KLEIN = u"SC_HID_FUNC_KLEIN"_ustr; -inline constexpr OUString HID_FUNC_WERT = u"SC_HID_FUNC_WERT"_ustr; +inline constexpr OUString HID_FUNC_VALUE = u"SC_HID_FUNC_VALUE"_ustr; inline constexpr OUString HID_FUNC_TEXT = u"SC_HID_FUNC_TEXT"_ustr; inline constexpr OUString HID_FUNC_T = u"SC_HID_FUNC_T"_ustr; inline constexpr OUString HID_FUNC_ERSETZEN = u"SC_HID_FUNC_ERSETZEN"_ustr; diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx index 995f4dd76103..a0d371a32258 100644 --- a/sc/source/core/data/funcdesc.cxx +++ b/sc/source/core/data/funcdesc.cxx @@ -466,7 +466,7 @@ ScFunctionList::ScFunctionList( bool bEnglishFunctionNames ) { SC_OPCODE_LOWER, ENTRY(SC_OPCODE_LOWER_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_KLEIN, 1, { 0 }, 0 }, { SC_OPCODE_LEN, ENTRY(SC_OPCODE_LEN_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_LAENGE, 1, { 0 }, 0 }, { SC_OPCODE_T, ENTRY(SC_OPCODE_T_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_T, 1, { 0 }, 0 }, - { SC_OPCODE_VALUE, ENTRY(SC_OPCODE_VALUE_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_WERT, 1, { 0 }, 0 }, + { SC_OPCODE_VALUE, ENTRY(SC_OPCODE_VALUE_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_VALUE, 1, { 0 }, 0 }, { SC_OPCODE_CLEAN, ENTRY(SC_OPCODE_CLEAN_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_SAEUBERN, 1, { 0 }, 0 }, { SC_OPCODE_CHAR, ENTRY(SC_OPCODE_CHAR_ARY), 0, ID_FUNCTION_GRP_TEXT, HID_FUNC_ZEICHEN, 1, { 0 }, 0 }, { SC_OPCODE_LOG10, ENTRY(SC_OPCODE_LOG10_ARY), 0, ID_FUNCTION_GRP_MATH, HID_FUNC_LOG10, 1, { 0 }, 0 }, I'd prefer solution 2 since we should replace German language by English language (WERT -> VALUE) but perhaps there are good reasons here to keep German language? Eike: any thoughts here?
I also prefer #2. Keeping German Help IDs was always only because Help depended on them and to avoid unnecessary work for Help authors, e.g. back in the days sections were marked as new and to be translated if ID changed (may be different today); but if they mismatch already there IMHO is no reason to not do it right.
(In reply to Eike Rathke from comment #3) > I also prefer #2. Keeping German Help IDs was always only because Help > depended on them and to avoid unnecessary work for Help authors, e.g. back > in the days sections were marked as new and to be translated if ID changed > (may be different today); but if they mismatch already there IMHO is no > reason to not do it right. Thank you Eike for the feedback! I've just submitted this on gerrit: https://gerrit.libreoffice.org/c/core/+/184960
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6c271e1bbb6e85ea7fc29cba20e9df193d5b69b5 tdf#166407: fix help page for the VALUE function It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Cherry-pick for 25.2 branch waiting for review here: https://gerrit.libreoffice.org/c/core/+/184962
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-25-2": https://git.libreoffice.org/core/commit/3176efaa5df50c202a6e45cd219d1f458fd3bded tdf#166407: fix help page for the VALUE function It will be available in 25.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.