Description: Import RTF: Incorrect endnote indent Steps to Reproduce: 1. Open the attached file (RTF export by LibreOffice 4.4.7.2 of attachment 199593 [details]; Bug 165564) Actual Results: There should be indent between numbering and text Expected Results: No indent Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: feb3c03b70ac1534a187e390c3bc1604a919ce12 CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded and in Version: 7.0.7.0.0+ (x64) Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Fine with Versie: 6.4.0.2 (x86) Build ID: 08d19fecdc7a2298d051e19cfdb7c35544855fc3 CPU-threads: 4; Besturingssysteem: Windows 10.0 Build 19045; UI-render: GL; VCL: win; Locale: nl-NL (nl_NL); UI-taal: nl-NL Calc: CL
Confirm Version: 25.2.3.2 (X86_64) / LibreOffice Community Build ID: bbb074479178df812d175f709636b368952c2ce3 CPU threads: 8; OS: Linux 6.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Flatpak Calc: threaded
Am I the only one who has this issue with the original odt? Bisection for indentation using odt file Version: 24.2.1.0.0+ (X86_64) / LibreOffice Community Build ID: dbb8a9c01fd6693df32f0a9c023b7be2c623cf7a author Mike Kaganski <mike.kaganski@collabora.com> commit dbb8a9c01fd6693df32f0a9c023b7be2c623cf7a (patch) tree 61beb76e1a70c8e6cf0d8550b5a937a4503d067e parent 87f11c2961cd4bb8be6bc8f62442a706da0420b7 (diff) Related: tdf#159382 Naming is hard: make initial monster shorter Rename "NoSpaceAfterHangingFootnoteNumbering" and friends to "NoGapAfterNoteNumber". This is cleaner, no less descriprive. Change-Id: I87d3103e4ddfc05e5604eaa4fe707b1fd5711aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162654
RTF and ODT were different. reproduce Version: 7.0.6.2 (x86) Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 12; OS: Windows 10.0 Build 26100; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL fine Version: 6.4.7.2 (x86) Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
It looks like there is an indentation in the master on Win64-7.0. Version: 7.0.7.0.0+ (x64) Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08 CPU threads: 12; OS: Windows 10.0 Build 26100; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: en-US Calc: CL Is there a difference between release and bibisect repository?
Created attachment 200648 [details] Example 4.4.7.2 export
The RTF generated by LibreOffice 4.4.7.2 of attachment 199593 [details] started rendering differently since somewhere in the 5.2 branch. Next it used to be broken until 6.4.0.2 where magically being OK. Next it's bad again. Apparently a lucky hit that the version below works, it's bad in whole 6.4 bibisect repro. Versie: 6.4.0.2 (x86) Build ID: 08d19fecdc7a2298d051e19cfdb7c35544855fc3 CPU-threads: 4; Besturingssysteem: Windows 10.0 Build 19045; UI-render: GL; VCL: win; Locale: nl-NL (nl_NL); UI-taal: nl-NL Calc: CL It's bad in Version: 5.2.5.0.0+ Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8 CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55 Locale: nl-NL (nl_NL); Calc: CL It's good in Versie: 5.2.2.1 Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Locale: nl-NL (nl_NL); Calc: group
Created attachment 200650 [details] ODT saved as RTF by LibreOffice 6.1.6.3 Opening the RTF generated by LibreOffice 6.1.6.3 lost the indent with commit tdf#152425 Synchronize import and export style names mapping 1. Make the mapping in StyleSheetTable::ConvertStyleName match the opposite direction mapping happening in MSWordStyles::GetWWId and ww::GetEnglishNameFromSti. Add missing styles, provide comments to clarify the process and find respective pool format ids. 2. Instead of appending " (user)" to conflicting style names, which is the method used by SwStyleNameMapper to disambiguate API names, append " (WW)", which allows to avoid unwanted merging conflicting styles.
https://gerrit.libreoffice.org/c/core/+/145349
I think that if the UI language when saving the RTF file is the same as the UI language when opening it, the indentation will be displayed correctly. However, if you open an RTF file saved in English with a UI in another language, the footnotes will not have an indent, but the end notes will have an indent.
Created attachment 200671 [details] Example 4.4.7.2(en)rtf The indentation is wider compared to the RTF file saved with the English UI, but there is still indentation. Version: 6.1.0.0.alpha0+ Build ID: 946fee3ef1e319ad63a599b72dbd55ef52cbc640 author Justin Luth commit 946fee3ef1e319ad63a599b72dbd55ef52cbc640 tdf#106062 ooxmlimport: skip fake tab only on hanging indent Export has changed, so that it only exports a tab when the footnote paragraph has a hanging indent. Adjusting the import code to match that change. Please test with MSO before flagging this patch as a regression. Certainly there will be some documents previously saved by LO which will now, in LO, show an extra tab character after the footnote. Any previously saved document without a hanging indent will display this extra tab. However, MSO has always seen that extra tab, so these patches are enhancing compatibility. This patch corrects several incorrect assumptions: -The paragraph style is not necessarily "Footnote". -The paragraph may have directly defined a hanging margin. -An aesthetic tab is needed on a hanging indent, not a defined margin. Change-Id: Ieaa76448ce202d92efdb8d1fc04ba2674ed120ba Reviewed-on: https://gerrit.libreoffice.org/52172
*** This bug has been marked as a duplicate of bug 166529 ***