Bug 166485 - Memory usage increases with > 2 GB after accepting/ rejecting all changes
Summary: Memory usage increases with > 2 GB after accepting/ rejecting all changes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.7.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2025-05-06 19:36 UTC by Telesto
Modified: 2025-05-09 13:22 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample (324.99 KB, application/vnd.oasis.opendocument.text)
2025-05-06 19:38 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2025-05-06 19:36:40 UTC
Description:
Memory usage increases with > 2 GB after accepting all changes

Steps to Reproduce:
1. Open the attached file
2. Open a process manager to check memory usage
3. Edit -> Track Changes -> Accept all

Actual Results:
Memory usage increases from 300mb to 2,8 GB

Expected Results:
Somewhere in the 300-500 MB range


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: feb3c03b70ac1534a187e390c3bc1604a919ce12
CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2025-05-06 19:38:09 UTC
Created attachment 200679 [details]
Sample
Comment 2 Telesto 2025-05-06 19:47:55 UTC
Same effect, with reject all

Less (1,8 GB), but also in 
Version: 7.6.3.0.0+ (X86_64) / LibreOffice Community
Build ID: 35f19e5cb93ce218787904e99c2bedfd40e725cc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

Also 1,8 GB in
Version: 7.3.8.0.0+ (x64) / LibreOffice Community
Build ID: e1ad83ddb2f39419fb5d7c69eba51e2b9f49c788
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Fine 
Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 3 Telesto 2025-05-06 19:52:57 UTC
Same effect - I assume the same root cause - but different way of reproducing:

1. Open attachment 165491 [details]
2. Enable Track changes recording: Edit -> Track Changes -> Record ON
3. Select a full table column & hit Delete Column -> Memory usage will skyrocket to 4,5 GB
Comment 4 m_a_riosv 2025-05-06 21:29:17 UTC
Reproducible with
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 31108d19e4643cd0fa515a57128fef22d0274ed7
CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-GB
Calc: CL threaded

But it is an Undo issue, setting up the undo steps to zero on advanced configuration, doesn't show such behavior.
Comment 5 Saburo 2025-05-09 03:39:24 UTC
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 48898a72066ff9982feafebb26708c4e779fd460

author	László Németh
commit 48898a72066ff9982feafebb26708c4e779fd460

tdf#60382 sw xmloff: import/export tracked table/row deletion
to OpenDocument format using

<style:table-row-properties loext:text-changes-only="false"/>

Rename also com::sun::star::text::TextTableRow::IsNotTracked
to com::sun::star::text::TextTableRow::HasTextChangesOnly.

Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
"tdf#60382 sw offapi: add change tracking of table/row deletion".

Change-Id: Iefb0d4095af0983fdd15697d5b80073d18d21bd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116212
Comment 6 Saburo 2025-05-09 07:43:51 UTC
Comment 3 Delete Column
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d1004cdd6a445ae73673b0ca360ae034b0ec09f2

author	László Németh
commit d1004cdd6a445ae73673b0ca360ae034b0ec09f2

tdf#150673 sw offapi: add change tracking of table column deletion
This is a minimal extension of the text range based change
tracking to record and apply table column deletions with full
Undo/Redo support.

Add property HasTextChangesOnly to com::sun::star::text::CellProperties.

During recording of track changes, deletion of table columns wasn't
recorded: columns were removed completely with their text content.
Now the deletion deletes the cell content with change tracking,
setting also HasTextChangesOnly property of table cells to FALSE. If
a tracked deletion is accepted in a deleted column, and the result
is an empty cell, the column will be removed, if HasTextChangesOnly
property of the deleted cell is FALSE.

Note: Deletion of empty columns isn't recorded. Hiding deleted
columns hasn't been supported yet in the Hide Changes mode.

Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
"tdf#60382 sw offapi: add change tracking of table/row deletion".

Change-Id: I36915d7a58f66b4a3bdaf90495cb998d29c36561
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151593