Description: UI: Reinstate button doesn't exist in the Track Changes -> Manage window Steps to Reproduce: 1. Open Writer 2. Edit -> Track changes -> Manage Actual Results: No reinstate button Expected Results: The feature shouldn't be limited to the right click context menu Reproducible: Always User Profile Reset: No Additional Info: Version: 25.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 17e8dbead42e2d4b55815b1b7b2846b03d62a15d CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
Thank you for reporting the bug. I can confirm that the bug is present in v25.8 of LibreOffice below. Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9bc5b89c149497a83117edfadc3fb0b96d2f9899 CPU threads: 2; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Of note is that the 'reinstate' option does not appear in either the 'Edit'->'Track Changes'->'Manage' menu or the right-click menu in version 25.2 below. Version: 25.2.3.2 (X86_64) / LibreOffice Community Build ID: bbb074479178df812d175f709636b368952c2ce3 CPU threads: 2; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
Both, main menu as well as context menu provide access to .uno:ReinstateTrackedChange. Adding this function as another action button in the Manage TC dialog with a potentially long name (bug 166723) spoils the dialog making it unnecessarily large. And as a new line under the current action buttons draws too much attention to it, and looks awkward too. We also need to consider the TC sidebar, which AFAIK resembles the Manage TC dialog. A potential solution might be a menu button. Reinstate might be seen as a flavor of accepting a change. I wouldn't object a toolbar button (View > Toolbars > Track Changes) but this requires an icon first.
(In reply to Heiko Tietze from comment #2) > Both, main menu as well as context menu provide access to > .uno:ReinstateTrackedChange. > > Adding this function as another action button in the Manage TC dialog with a > potentially long name (bug 166723) spoils the dialog making it unnecessarily > large. An In principle I agree. Although, I do find it little obscure to put it a context menu though. 1 )It's more cumbersome to access. A) Right Click on the proper spot B) Find to the proper item in the menu C) Hoover to the proper item D) Press reinstate 2) Disrupts flow. Especially If you using the Track Changes Manage sidebar to manage comments. I did overlook this initially while reporting the enhancement 3) Makes the feature less prominent The label could be replaced by icons (with mouse-over label). No clue if it's allowed: I don't know much about good practices regarding UI design
Icon-only buttons are an alternative, that's true. But it comes on cost of accessibility and usability. Whether it justifies the odds depends on how many user will rather reinstate than accept/reject. Doubt this at the time being.
(In reply to Heiko Tietze from comment #4) > Whether it justifies the odds depends on how many user will rather reinstate than accept/reject. Doubt this at the time being. I can surely not predict how commonly the feature would be used. OTOH, making it less accessible won't help the adaptation. I'm more interpreting this from perspective UI consistency. A) Having access from a feature using route A, not from B feels odd B) You can't manually add a button to the dialog. Overall my 2 cents on the matter.
(In reply to Telesto from comment #5) > OTOH, making it less accessible won't help the adaptation. Indeed. We've got space for this button, let's add it. Even if we were to add icons to the buttons (which we probably should), at worst we would need an extra row of buttons, and I'm still ok with that.