Description: Convert theme dialog to IconView widget for enhancement as native GTK widget is better and it would also improve web-based libreoffice experience. Steps to Reproduce: 1. Open any document 2. Go to Format 3. Click on Theme Actual Results: Theme dialog uses a ValueSet widget to display theme options. Expected Results: It will now use native IconView widget instead of ValueSet widget. Reproducible: Always User Profile Reset: No Additional Info: Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f221fa6d3022fcb51d23329828b306b4ffaa49a8 CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Would we loose the color swatch representation (Dark1, Light + 6 accents) for each Color Theme visible now in the dialog? What would the new "native IconView widget" present if not the color swatches?
(In reply to V Stuart Foote from comment #1) > Would we loose the color swatch representation (Dark1, Light + 6 accents) > for each Color Theme visible now in the dialog? > > What would the new "native IconView widget" present if not the color > swatches? It would present the same color swatches, but using an GTK native IconView instead of ValueSet, which is a LO custom widget. Custom widgets have several issues when using welding (non-native look, HiDPI for example). When using JS dialog, we need to send the bitmaps of the whole widget to the client (and listen to mouse events when clicking on the presented bitmap and send those back to the LO core) instead of individual color swatches. This is why we are working on converting usages of the ValueSets to IconView.
Parth Raiyani committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d1192753bf14dc01e81061ed8e9b01443070478 tdf#167074 Switch to IconView in ThemeDialog for improved UI handling It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can this be closed as fixed?
(In reply to Buovjaga from comment #4) > Can this be closed as fixed? Yes, I believe we can. Let me do that.