Bug 167162 - Unused "script indicator" config option
Summary: Unused "script indicator" config option
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:26.2.0
Keywords:
Depends on:
Blocks: UI-Theming Writer-Comments
  Show dependency treegraph
 
Reported: 2025-06-22 14:30 UTC by Stanislav Horacek
Modified: 2025-09-26 08:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Horacek 2025-06-22 14:30:52 UTC
The "script indicator" option seems to be unused and it probably should be removed from the configuration.

See:
- search for it in the codebase: https://github.com/search?q=repo%3ALibreOffice%2Fcore%20WRITERSCRIPTINDICATOR&type=code
- Heiko's comment on this: https://community.documentfoundation.org/t/script-indicator-in-writer/13071/2

The option appears among the items whose color can be set listed on the Appearance options page (introduced in 25.2) - setting this option has no effect which can be confusing for users.
Comment 1 Heiko Tietze 2025-09-24 11:56:24 UTC
The script indicator is used in the comments paint method SwViewOption::PaintPostIts() if bIsScript is true. Cannot find a way to make this true, trying with <scrip> in a html document (which is just ignored).

Some random thoughts
* sw/source/core/text/txtfld.cxx:101 suggests we have something like a "script field"
* com.sun.star.text.TextField.Script on the uno api, sw/source/filter/html/swhtml.cxx:711  may suggest this has something to do with <script> in the HTML import
* we used to map <!-- foo --> into Writer comments

In any case, this does not need a user-customizable color. Going to change it into a hard-coded default.
Comment 2 Heiko Tietze 2025-09-24 12:15:09 UTC
Patch submitted at https://gerrit.libreoffice.org/c/core/+/191442
Comment 3 Commit Notification 2025-09-26 08:15:22 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c6c9cf48ad78153e907b995193d8ba8c4b1d433a

Resolves tdf#167162 - Remove color customization for Script Indicator

It will be available in 26.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.