Created attachment 201671 [details] Screen recording See screen recording where I just pick arbitrary year entries from a date column, click the new "Lock" option, then OK and the application crashes.
Created attachment 201672 [details] My test document Test document with a database range "Import1" and auto-filter set.
Reproducible Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 36a55369a6ac72ae985cf31405b7f52686665d84 CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Raster; VCL: win Locale: en-US (es_ES); UI: en-US Calc: CL threaded Versions with Lock option crash, it has begun with 24.2
Implemented in bug 133836
*** Bug 169594 has been marked as a duplicate of this bug. ***
Created attachment 204229 [details] GDB trace of crash
@Andreas thanks for reporting the issue, i can reproduce it. back when i implemented it, i was a half baked programmer, not that things have changed drastically since then ;). i will push a fix shortly :).
I remember now, (after looking at the code), in the code, there's this condition which checks if the entry is a date or not, and i had no idea on how to handle dates, so i only added the lock related code for entries which are not dates :).
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f4c2bd3e3e712316e0d46b4f803b3bdc4f6ee5c Related tdf#167395: Break out of the loop after the entry has been found It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b3fc9d9280076973bcc47c3fbb03fc179ec17e26 Related tdf#167395: Use descriptive variable name for returned value It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3a51cd8cb3cc40615c86d1a158c0135b4f27a3ef Related tdf#167395: Formatting change It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4ea90e89422bd5dc5a31a986e8f6007c89df77da Related tdf#167395: Remove unnecessary variable `mbChecked` It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a034a2bce6d4cf5bb6de850c4d4367f91a8a9300 Related tdf#167395: Add comments, make variable names readable It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
this would take a little while, maybe a week or two. i pushed some code improvements, added a lot of comments. if someone wants to work on it in the meantime, please do so. these commits should make the code a little more readable.