Created attachment 201671 [details] Screen recording See screen recording where I just pick arbitrary year entries from a date column, click the new "Lock" option, then OK and the application crashes.
Created attachment 201672 [details] My test document Test document with a database range "Import1" and auto-filter set.
Reproducible Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 36a55369a6ac72ae985cf31405b7f52686665d84 CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Raster; VCL: win Locale: en-US (es_ES); UI: en-US Calc: CL threaded Versions with Lock option crash, it has begun with 24.2
Implemented in bug 133836
*** Bug 169594 has been marked as a duplicate of this bug. ***
Created attachment 204229 [details] GDB trace of crash
@Andreas thanks for reporting the issue, i can reproduce it. back when i implemented it, i was a half baked programmer, not that things have changed drastically since then ;). i will push a fix shortly :).
I remember now, (after looking at the code), in the code, there's this condition which checks if the entry is a date or not, and i had no idea on how to handle dates, so i only added the lock related code for entries which are not dates :).
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f4c2bd3e3e712316e0d46b4f803b3bdc4f6ee5c Related tdf#167395: Break out of the loop after the entry has been found It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b3fc9d9280076973bcc47c3fbb03fc179ec17e26 Related tdf#167395: Use descriptive variable name for returned value It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3a51cd8cb3cc40615c86d1a158c0135b4f27a3ef Related tdf#167395: Formatting change It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4ea90e89422bd5dc5a31a986e8f6007c89df77da Related tdf#167395: Remove unnecessary variable `mbChecked` It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a034a2bce6d4cf5bb6de850c4d4367f91a8a9300 Related tdf#167395: Add comments, make variable names readable It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
this would take a little while, maybe a week or two. i pushed some code improvements, added a lot of comments. if someone wants to work on it in the meantime, please do so. these commits should make the code a little more readable.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/26c15c6f6b531f6932628f05ce26c77746fe8c3f Related: tdf#167395 avoid crash by skipping the code when mbHasDates It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f591aae9103464a803cf2af7224c644937c94fff Related: tdf#167395 add MarkCheckedMembers to mark checked entries It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c47aa01cc0700f235bb5fee1f88d1dac52dcb2c Related: tdf#167395 pass lowercase search text to loadSearchedMembers It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7d63f9fc615cba1cdc2c28b7c66901ab102b790f Related: tdf#167395 refactor shared code into UpdateVisibleMembers It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf3bc0d74f14f83b9b3cb77f18352304ab2a546e Related: tdf#167395 don't disable the date entries unnecessarily It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d81d50be930f9b91e1ee20ad664c5387eb19583c fix: tdf#167395 make lock work with hierarchies of dates It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Sahil, is this issue fixed now ?
(In reply to Xisco Faulí from comment #20) > @Sahil, is this issue fixed now ? yes, it doesn't crash with dates anymore, and locking works as expected.
(In reply to Sahil Gautam (Collabora) from comment #21) > (In reply to Xisco Faulí from comment #20) > > @Sahil, is this issue fixed now ? > > yes, it doesn't crash with dates anymore, and locking works as expected. Then please close as fixed :)
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/5cc4b06da962a02ebd41fcb84c9a682b79b03b70 Related tdf#167395: Break out of the loop after the entry has been found It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/feea317ac9c1f16ce49dad22b7f9cc3ebdb7ffe9 Related tdf#167395: Use descriptive variable name for returned value It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/31700187ad619aadb0fa3027283233cf4c5c6b6e Related tdf#167395: Formatting change It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/e9a4617580493163a865af2ae472906373456f56 Related tdf#167395: Remove unnecessary variable `mbChecked` It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/ef7033392c8d363cf758a29ef434aa1aa6ee9874 Related tdf#167395: Add comments, make variable names readable It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/7711639e0c5a2d690981cb3d41139473fb996a48 Related: tdf#167395 avoid crash by skipping the code when mbHasDates It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/5693eb822e351342d17d51db0e29d8a9d1dc6050 Related: tdf#167395 add MarkCheckedMembers to mark checked entries It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/a1162bb2dd2ca55ce428d2a07af41aa9b92982ea Related: tdf#167395 pass lowercase search text to loadSearchedMembers It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/a7a27b09cc5416c51883b3e026e08253a696014e Related: tdf#167395 refactor shared code into UpdateVisibleMembers It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/385def53e76d7cf1472ebceced1e595692e17ec9 Related: tdf#167395 don't disable the date entries unnecessarily It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/db993eaf302015f11c5c9a7c8c4c43be01b7ba8a fix: tdf#167395 make lock work with hierarchies of dates It will be available in 26.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.