Description: Enhanced presets and shadow styles to use IconView widget instead of Valueset widget as native GTK widget is better. It would also improve web-based libreoffice experience. Steps to Reproduce: 1. Open any document 2. Go to Format 3. Click on Cell 4. Select Borders Actual Results: 1. Presets uses ValueSet widget to display border presets. 2. Shadow Styles uses ValueSet widget to display border shadows. Expected Results: 1. Presets will now use IconView widget to display border presets. 2. Shadow Styles will now use IconView widget to display border shadows. Reproducible: Always User Profile Reset: No Additional Info: Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be7df84972a3440497e511c30f74cb05ce44cf2 CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Parth Raiyani committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4d6429c0368f9b2ec796dd8468defbee194a8b4c tdf#167536 Switch to IconView for presets and shadows in border page It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7fc56525ed18de950d3892d69942f8dc8d15f22b tdf#167536 cui: Set a11y names for IconView items in borders tab page It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be2287c5d2081b7de68d73cc657f5b249d19a082 tdf#167536 cui a11y: Set IconViews as mnemonic widgets for their labels It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 201934 [details] Screenshot with qt6 VCL plugin
The commits from comment 2 and 3 make announcement of the items by screen readers work again after the commit from comment 1. (If you plan to do more ValueSet -> IconView changes, it would be nice to keep an eye on that.) attachment 201934 [details] shows a screenshot with the qt6 VCL plugin (and I'd expect it to be similar on Windows or macOS, but haven't tested explicitly), which looks quite different from gtk3. Is that intended?
(In reply to Michael Weghorn from comment #5) > The commits from comment 2 and 3 make announcement of the items by screen > readers work again after the commit from comment 1. > (If you plan to do more ValueSet -> IconView changes, it would be nice to > keep an eye on that.) Thanks :) Will keep an eye on this. > attachment 201934 [details] shows a screenshot with the qt6 VCL plugin (and > I'd expect it to be similar on Windows or macOS, but haven't tested > explicitly), which looks quite different from gtk3. Is that intended? No it's not. I haven't tried with gt6 VCL plugin but it should be same as gtk3(presets and shadows icons should be on same row). I'm not sure why it is showing differently.
(In reply to Parth Raiyani from comment #6) > No it's not. I haven't tried with gt6 VCL plugin but it should be same as > gtk3(presets and shadows icons should be on same row). I'm not sure why it > is showing differently. It's a separate implementation of the weld::IconView interface: GtkInstanceIconView (using a GtkIconView widget) for gtk3, SalInstanceIconView (using a vcl IconView widget) for qt6 (unless using SAL_VCL_QT_USE_WELDED_WIDGETS=1 and a dialog that's already supported for native Qt widgets, see tdf#130857), gen, Windows and macOS, so that implementation might need to be looked into separately.
(In reply to Michael Weghorn from comment #7) > It's a separate implementation of the weld::IconView interface: > GtkInstanceIconView (using a GtkIconView widget) for gtk3, > SalInstanceIconView (using a vcl IconView widget) for qt6 (unless using > SAL_VCL_QT_USE_WELDED_WIDGETS=1 and a dialog that's already supported for > native Qt widgets, see tdf#130857), gen, Windows and macOS, so that > implementation might need to be looked into separately. (And IIUC, there's JSIconView for Collabora Online, which I think is based on SalInstanceIconView, but I'm not familiar with that.)