Bug 168768 - Reject All Changes Freezes Writer
Summary: Reject All Changes Freezes Writer
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Floatingtable
  Show dependency tree / graph
 
Reported: 2025-10-09 10:27 UTC by Telesto
Modified: 2025-10-09 18:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2025-10-09 10:27:24 UTC 
Description:
Reject All Changes Freezes Writer

Steps to Reproduce:
1. Open attachment 203214 [details] (bug 168753) possibly also same cause as bug 168753
2. Edit -> Track Changes -> Reject All

Actual Results:
Freeze

Expected Results:
Reject Change


Reproducible: Always


User Profile Reset: No

Additional Info:
Found in
Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b1c0c4838d2e006ffa8e72516569ce8d13bdbe01
CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

and in
Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: f461853b11439c4e485a79174d34735395e5bf52
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded


fine in
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6f227b0dd912d4c70a01eb3872fff15d52de543a
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2025-10-09 10:35:37 UTC 
Bisected to
/win64-24.2 ((54782b933...)|BISECTING)
$ git bisect good 40b4acacb8ac7aefd246c9cdeea4627a7aad91ed is the first bad commit
commit 40b4acacb8ac7aefd246c9cdeea4627a7aad91ed
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed Oct 4 03:54:54 2023 -0700

    source 89a75cd194371002247d0138e759835bc673f7b0

    source 89a75cd194371002247d0138e759835bc673f7b0

-----
sw floattable, crashtesting: fix PDF export of ooo91654-1.doc

Regression from 89a75cd194371002247d0138e759835bc673f7b0 (tdf#126449 sw
floattable: DOC import: handle inner floating table, 2023-10-04), the
document crashed Writer layout when exporting to PDF, which triggers a
layout calculation.

The trouble seems to be that in case the split fly is anchored in a
table which is in a section, then we assume that we can create a section
on the next page and move the follow fly frame there, which will mean
the follow anchor won't be in a table anymore.

Fix this by not moving the follow anchor explicitly, similar to what the
nested floating table (inline or floating outer table) code does. The
layout will later figure out that the available space is not enough,
split the outer table for us, which will lead to a correct result.

Note that the original bugdoc is DOC, but just saving it as-is in Word
hides the problem, so it's not easy to minimize the reproducer. Instead
create a similar DOCX reproducer from scratch.

Change-Id: I769615af467ccaa88057ab322da2865f11d3d2ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157803
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Comment 2 raal 2025-10-09 18:46:57 UTC 
Confirm with Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8ea8e254a3151f5390f3a10ff156fcaf8e7c5d5c
CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded


Adding Cc: to 	Miklos Vajna ; Could you possibly take a look at this one?
Thanks