Created attachment 39034 [details] This gets rid of a great number of the comments There are a great number of places in calc where code is commented out with lines staring in "//UNUSED". Since 'git' is being used, there is no reason to keep old code like this in comments.
Comment on attachment 39034 [details] This gets rid of a great number of the comments The patch is contributed under GPL3+ if that makes a difference.
The patch is contributed under GPL3+ if that makes a difference...
Taking over.
Checked into the calc repo. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=0d9b86479b9cb9208079ead14479becab8dc24d3 The patch was applied as-is, except for one skipped hunk which accidentally modified a licensing header. Thanks for the patch. :-)
Sorry, contributions need to be LGPL3, not GPL3. But does a patch that only *removes* lines actually introduce anything that the patch creator would hold copyright on? Interesting question, but I guess yes, as a whole it affects the work and thus introduces you as a copyright holder. So if you indeed insist on using GPL3 and not LGPL3 for the patch, I am afraid it can't be accepted.
Oh yeah, that's a very important point. Justin, as Tor said, we cannot accept GPL3. Could you confirm that your patch is contributed under LGPL3 ? Please let us know ASAP, or else we'll have to revert your change.
He re-submitted an identical (except for one hunk which I didn't apply) patch under LGPL3: http://lists.freedesktop.org/archives/libreoffice/2010-September/000045.html Problem solved.
Created attachment 39049 [details] I think that this eliminates the remaining //UNUSED comments There were still some of these comments (actually, a lot of them). The most recent attachment should get rid of the last of them. The file is contributed under LGPL3+. I had the same question about simple deletions. Sorry for the confusion.
Setting status to 'REOPENED' as not all such comments have been removed.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=10812e78236ef8e00c6d2bfad3998bea20ac88e1 Committed the last attached patch. Thanks a lot.
Closing - Sophie
This is a Calc issue, therefore changed the 'Component' field appropriately.