Bug 30714 - Use different default key bindings for inserting current date and time for Hungarian locale.
Summary: Use different default key bindings for inserting current date and time for Hu...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Kohei Yoshida
URL:
Whiteboard: target:3.5
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 11:37 UTC by Kohei Yoshida
Modified: 2011-12-13 06:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Patch to test. (4.92 KB, text/plain)
2011-12-12 15:51 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kohei Yoshida 2010-10-08 11:37:41 UTC
http://lists.freedesktop.org/archives/libreoffice/2010-October/000532.html

Problem: Semicolon is not a good choice for my locale (hu), because it is
mapped to AltGr+, therefore shortcut key does not work.

Solution: Shortcuts are Ctrl+. and Ctrl+Shift+. in Hungarian Excel.  Perhaps we could do the same in Calc.
Comment 1 Rainer Bielefeld Retired 2010-12-17 00:11:59 UTC
Seems we are talking about spreadsheet?
Comment 2 Kohei Yoshida 2011-01-04 16:12:23 UTC
Looks like the next significant release will be 3.4, not 3.3.1.  Resetting the target accordingly.
Comment 3 Kohei Yoshida 2011-12-12 12:55:52 UTC
Miklos, it's best that someone who has access to the Hungarian keyboard tackle this bug.  Do you think you'll be able to handle this?  I can provide pointers if needed, of course.
Comment 4 Miklos Vajna 2011-12-12 15:51:54 UTC
Created attachment 54381 [details]
Patch to test.

Andras, can you test the attached patch?

The cui and vcl changes are to be able to bind anything to Ctrl-'.' and Ctrl-Shift-'.', I tested that part.

However, I don't have a Hungarian build around, so the officecfg part is untested.

Thanks,

Miklos
Comment 5 Miklos Vajna 2011-12-13 05:36:53 UTC
Fixed by commits in master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b26292882bf2439a78488b55b4ac21c244ef61b1
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5916088332276b922a6a0d6d27968cd82569639c

(In the meantime I did a build with Hungarian locale, so no action from Andras is needed.)
Comment 6 Kohei Yoshida 2011-12-13 06:38:07 UTC
Feel free to cherry-pick it to the libreoffice-3-5 branch as this was originally targeted for 3.5.
Comment 7 Miklos Vajna 2011-12-13 06:42:06 UTC
Andras did that already.
Comment 8 Kohei Yoshida 2011-12-13 06:44:57 UTC
thanks