Bug 32007 - No "EvolutionLocal" database should be offered on non-Linux
Summary: No "EvolutionLocal" database should be offered on non-Linux
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.3.0 Beta3
Hardware: Other Windows (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 16:33 UTC by Kohei Yoshida
Modified: 2010-12-14 04:46 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
this should do it (1.64 KB, patch)
2010-12-01 04:26 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kohei Yoshida 2010-11-30 16:33:40 UTC
This happens on Windows.

1. Open Writer or Calc.
2. Hit F4 to display the registered database pane.  There, you should see two registered databases: Bibliography and EvolutionLocal.
3. Expand the EvolutionLocal database to show Queries and Tables sub tree elements.
4. Try to expand the Tables element.
5. You get the error message saying that the evolocal.odb does not exist.
Comment 1 Kohei Yoshida 2010-11-30 18:29:17 UTC
I think it's reasonable to hide that database at least for non-Linux platforms.
Comment 2 Drew Jensen 2010-11-30 22:58:16 UTC
Well, given that, IIRC, there is not even a driver for Evolution with the Windows builds I would say it is an error to include the reference. 

I wonder why it, the ODB file, is included under Linux even - no ODB file for MS Windows Address book is included with the Windows builds, no T'Bird or Mozilla address book ODB file is included with Linux or any other build AFAIK. (Would be great if I am wrong on that)

In the case of Address book data sources, and accompanying ODB files, I suppose it is rather a special case isn't it - since the ODB file can be created when needed from a number of different entry points in the application. The Base opening wizard, existing data source function, being only one; 

Also when created by the user, when first needed, the application does give an appropriate response if the user tries to create an ODB file, using a supplied driver, for an email client not installed on the user's system.

So quite different from the Bibliography dBase files.
Comment 3 Caolán McNamara 2010-12-01 01:36:54 UTC
This should be achievable by something like install:module="unx" in the appropriate node in registry/data/org/openoffice/Office/DataAccess.xcu
Comment 4 Drew Jensen 2010-12-01 04:22:55 UTC
If this where a true RC (no don't ask what 'true' means) build I would agree, without hesitation, that this is NOT a show stopper.

But - Assuming there is still another beta to come (?) and it is a simple change to a config file (and someone cares to do so), then I would strongly advocate not going to release with such an error - the reason is simple: This is the kind of error, even if only noticed by a few, that can cause people to use the term, Sloppy. Probably an email is much more appropriate to explain what I mean by this, rather then the issue tracker - then again wouldn't be surprised at all if you may all know exactly mean.
Comment 5 Caolán McNamara 2010-12-01 04:26:49 UTC
Created attachment 40697 [details]
this should do it
Comment 6 Drew Jensen 2010-12-01 04:34:57 UTC
Ok great - having spoke the work sloppy it seems I then clicked the wrong button and plowed over the status change and assignment change from Caolán, sorry :-/
Comment 7 Caolán McNamara 2010-12-01 04:59:40 UTC
Fix checked in, added it to libreoffice-3.3 as well
Comment 8 Caolán McNamara 2010-12-10 03:53:30 UTC
caolanm->kohei: Can you confirm that this is good on windows now ?
Comment 9 Kohei Yoshida 2010-12-10 07:27:33 UTC
Yup, this is good now on Windows.  Thanks Caolan.