Bug 32563 - Preamble of LICENSE.odt is not localizable
Summary: Preamble of LICENSE.odt is not localizable
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.3.0 RC1
Hardware: All All
: medium blocker
Assignee: Jan Holesovsky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 31865
  Show dependency treegraph
 
Reported: 2010-12-21 15:13 UTC by Martin Srebotnjak
Modified: 2011-01-22 05:00 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
The patch. (10.47 KB, patch)
2010-12-28 17:03 UTC, Jan Holesovsky
Details
Screenshot of the dialog. (48.64 KB, image/png)
2010-12-28 17:10 UTC, Jan Holesovsky
Details
Updated patch. (9.80 KB, patch)
2010-12-29 08:01 UTC, Jan Holesovsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Srebotnjak 2010-12-21 15:13:51 UTC
LICENSE.odt that opens after clicking "LibreOffice Credits..." in the Help menu is not localized.
As I pointed out on the l10n mailing list - the first part of the document (preamble) must be localized for all languages or made part of a dialogue and then with a link the (untranslated) English license text opens.
I do understand that the license cannot be localized.
But this document does not conatain license only, it contains this preamble and that preamble should explain why the license is in English and be fully localizable.

This is a blocker for all non-English versions of LibreOffice.
Comment 1 Jan Holesovsky 2010-12-28 17:03:37 UTC
Created attachment 41498 [details]
The patch.

This implements the separate localizable dialog that contains the preamble; for libreoffice-3-3.  Please check both the implementation, as well as the wording of the dialog.
Comment 2 Jan Holesovsky 2010-12-28 17:10:51 UTC
Created attachment 41499 [details]
Screenshot of the dialog.
Comment 3 Olivier Hallot 2010-12-29 01:53:03 UTC
May I suggest to add the following lines in this dialog?. I took it from the readme and it help many would-be users to make sure they will not be charged in the future (a recurrent question in our communities).


${PRODUCTNAME} is free for use by everybody. You may take this copy of ${PRODUCTNAME} and install it on as many computers as you like, and use it for any purpose you like (including commercial, government, public administration and educational use). For further details see the license text packaged with this ${PRODUCTNAME} download.
Comment 4 Jan Holesovsky 2010-12-29 08:01:15 UTC
Created attachment 41505 [details]
Updated patch.

This patch is an updated version that

* Computes size of the buttons to avoid trouble with languages with long words
* Splits the text to 5 paragraphs
* Uses %PRODUCTNAME instead of "This product"

I am sorry, but this does not introduce the proposal of explanation of consequences of LGPL, as I consider it incomplete, and the original purpose of this dialog was not to explain all of that.
Comment 5 Michael Meeks 2011-01-06 08:50:51 UTC
I reviewed, tested the patch and pushed it.
I also removed the English pre-amble to that document; it now reads (purely):

- DO NOT TRANSLATE OR LOCALIZE THIS DOCUMENT -

I hope that piece is ok.
Comment 6 sophie 2011-01-22 05:00:58 UTC
Verified in RC4FR- Closed - Sophie