Bug 32633 - Title pages dialog box: need space for localization
Summary: Title pages dialog box: need space for localization
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.3.0 RC2
Hardware: All All
: medium major
Assignee: Caolán McNamara
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-24 01:31 UTC by Olivier Hallot
Modified: 2011-01-22 06:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
dialog box of title pages (20.18 KB, image/png)
2010-12-24 01:32 UTC, Olivier Hallot
Details
how it looks now (38.39 KB, image/png)
2011-01-04 02:51 UTC, Caolán McNamara
Details
rc3 hu (7.34 KB, image/png)
2011-01-13 03:58 UTC, Andras Timar
Details
rc3 de (6.82 KB, image/png)
2011-01-13 03:58 UTC, Andras Timar
Details
patch for review (1.09 KB, patch)
2011-01-14 03:47 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2010-12-24 01:31:08 UTC
Hi, 

The attached image shows how the Title Page dialog box appears in Brazilian Portuguese. 

The red underlines shows strings truncated. We must shift the green and the magenta uderlined srings and objects to the right for at least 5 characters.

The magenta underline shows an object that should be shifted at least 5 characters to the right.

The blue and yellow underline need much more space and may require to enlarge the dialog box.
Comment 1 Olivier Hallot 2010-12-24 01:32:07 UTC
Created attachment 41412 [details]
dialog box of title pages
Comment 2 Rainer Bielefeld Retired 2010-12-24 01:38:30 UTC
This sounds very similar to Bug 32133
Comment 3 Olivier Hallot 2010-12-24 02:02:56 UTC
Different module (writer)
Different place (Title pages)

Should be kept as a separated bug from bug 32133
Comment 4 Kohei Yoshida 2010-12-24 08:30:34 UTC
I believe this is Caolan's feature.
Comment 5 Caolán McNamara 2010-12-24 09:03:01 UTC
Bah, have to reshuffle the dialog a bit to make it fit. Old-school fixed positioning dialogs.
Comment 6 Olivier Hallot 2010-12-24 09:10:10 UTC
Please have a rule of thumb that latin languages strings are 30 to 50% longer than english (empiric estimation)...
Comment 7 Caolán McNamara 2011-01-04 01:29:05 UTC
The translations in the screenshot don't appear to actually be in the git repos, is that right ?
Comment 8 Olivier Hallot 2011-01-04 01:53:34 UTC
Actually I am surprised if not... how can they be in the RC2 build if so?

I may however have modified the strings to make them a little shorter since then. Are you looking for the exact string in the git repository?

Example: In pootle we have now

Set Page Number for first title page = 
Definir o N.º da página para a 1.ª página de título


Reset Page Numbering after title pages = 
Redefinir a numeração de páginas após as páginas de título

I am forwarding this to Andras Timar for comments.
Comment 9 Caolán McNamara 2011-01-04 02:04:34 UTC
Yeah, I found them, they're in the old-school ooo-build type wrapper module and get applied over the "vanilla" ones during that ooo-build style build, so they don't appear if I do a new-style build. Something to sort out post 3.3 I guess is to figure out how to get those merged into the "l10n" module rather than the "build" module seeing as we're migrating away from the "build" module and don't document it as the way to build libo.

Anyway, I'll do a quick test build and stick the screenshot here in a while.
Comment 10 Caolán McNamara 2011-01-04 02:51:54 UTC
Created attachment 41610 [details]
how it looks now
Comment 11 Olivier Hallot 2011-01-04 03:30:03 UTC
excellent!
Thanks Caolán!
Comment 12 Andras Timar 2011-01-13 03:58:16 UTC
Created attachment 41954 [details]
rc3 hu
Comment 13 Andras Timar 2011-01-13 03:58:49 UTC
Created attachment 41955 [details]
rc3 de
Comment 14 Andras Timar 2011-01-13 04:00:22 UTC
Edit button is still too small. Affected locales: bg, de, hu, ku, or (and possibly other locales in the future who have not translated this dialog yet). I attached two screenshots.
Comment 15 Caolán McNamara 2011-01-14 03:47:30 UTC
Created attachment 42015 [details]
patch for review
Comment 16 Caolán McNamara 2011-01-14 03:48:01 UTC
done in head and 3-3, need signoffs for 3-3-0 however
Comment 17 Caolán McNamara 2011-01-14 07:41:52 UTC
Got the acks, pushed to 3-3-0
Comment 18 sophie 2011-01-22 06:37:01 UTC
Verified in RC4 FR - Closed - Sophie