Bug 32840 - Make unopkg --suppress-license ignore the extension's description.xml content
Summary: Make unopkg --suppress-license ignore the extension's description.xml content
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.3.0 RC2
Hardware: Other All
: medium minor
Assignee: Cédric Bosdonnat
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 00:56 UTC by Cédric Bosdonnat
Modified: 2011-01-06 08:46 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bosdonnat 2011-01-05 00:56:54 UTC
the unopkg --suppress-license currently suppress the license only if the extension's description.xml contains the //simple-license[@suppress-if-required='true'] 

See: http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fregistration.2Fsimple-license

This unopkg option should skip the license approval in all cases without taking care of that property in the description.xml
Comment 1 Cédric Bosdonnat 2011-01-05 02:03:04 UTC
Fixed in master with commit:

http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=886f83999b5077e5299f31886937959f78da0b8c
Comment 2 David Tardon 2011-01-06 00:38:29 UTC
I suppose that help for the option should be updated as well: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=d348c231edbb59257512cd6cbae7f6a6d2ad9875 . Anyway, I will sign this off if we decide to push it into 3.3.
Comment 3 Michael Meeks 2011-01-06 07:51:51 UTC
Looks useful for corporate admins, and developers debugging their extensions; has had double code review; looks fine to me, lets get it in :-)
Comment 4 Michael Meeks 2011-01-06 08:46:26 UTC
pushed to libreoffice-3-3