Bug 33210 - menus do not build from desktop integration.
Summary: menus do not build from desktop integration.
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
3.3.0 RC3
Hardware: x86 (IA32) Linux (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 11:23 UTC by Jan de Kruyf
Modified: 2023-12-10 09:29 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan de Kruyf 2011-01-17 11:23:56 UTC
LibreOffice 3.3.0 
OOO330m19 (Build:5)
tag libreoffice-3.3.0.3

running on Debian - Squeeze
with FVWM desktop
no KDE
no Gnome, except some libraries perhaps.

The Debian menu does not build because the 'libreoffice-debian-menus' file has not been updated.

Also the menu Sections are not up to date.

Regards,

Jan de Kruyf.

Here is a diff to fix the menus file:

--- A/libreoffice-debian-menus	2011-01-17 19:25:50.747962609 +0200
+++ B/libreoffice-debian-menus	2011-01-17 19:08:34.475964834 +0200
@@ -1,39 +1,39 @@
-?package(libreoffice-writer):needs="X11" section="Apps/Editors"\
+?package(libreoffice3-writer):needs="X11" section="Apps/Office"\
   title="LibreOffice 3.3 Writer" command="libreoffice -writer"\
   hints="Word Processors"\
   kderemove="y"\
   icon="/usr/share/icons/hicolor/32x32/apps/libreoffice-writer.png"\
   icon16x16="/usr/share/icons/hicolor/16x16/apps/libreoffice-writer.png"
 
-?package(libreoffice-calc):needs="X11" section="Apps/Math"\
+?package(libreoffice3-calc):needs="X11" section="Apps/Office"\
   title="LibreOffice 3.3 Calc" command="libreoffice -calc"\
   hints="Spreadsheets"\
   kderemove="y"\
   icon="/usr/share/icons/hicolor/32x32/apps/libreoffice-calc.png"\
   icon16x16="/usr/share/icons/hicolor/16x16/apps/libreoffice-calc.png"
 
-?package(libreoffice-draw):needs="X11" section="Apps/Graphics"\
+?package(libreoffice3-draw):needs="X11" section="Apps/Office"\
   title="LibreOffice 3.3 Draw" command="libreoffice -draw"\
   hints="Drawing"\
   kderemove="y"\
   icon="/usr/share/icons/hicolor/32x32/apps/libreoffice-draw.png"\
   icon16x16="/usr/share/icons/hicolor/16x16/apps/libreoffice-draw.png"
 
-?package(libreoffice-impress):needs="X11" section="Apps/Graphics"\
+?package(libreoffice3-impress):needs="X11" section="Apps/Office"\
   title="LibreOffice 3.3 Impress" command="libreoffice -impress"\
   hints="Presentation"\
   kderemove="y"\
   icon="/usr/share/icons/hicolor/32x32/apps/libreoffice-impress.png"\
   icon16x16="/usr/share/icons/hicolor/16x16/apps/libreoffice-impress.png"
 
-?package(libreoffice-base):needs="X11" section="Apps/Databases"\
+?package(libreoffice3-base):needs="X11" section="Apps/Office"\
   title="LibreOffice 3.3 Base" command="libreoffice -base"\
   hints="Database"\
   kderemove="y"\
   icon="/usr/share/icons/hicolor/32x32/apps/libreoffice-base.png"\
   icon16x16="/usr/share/icons/hicolor/16x16/apps/libreoffice-base.png"
 
-?package(libreoffice-core02):needs="X11" section="Apps/System"\
+?package(libreoffice3):needs="X11" section="Apps/System"\
   title="LibreOffice 3.3 Printer Administration"\
   command="libreoffice-printeradmin"\
   hints="Setup,Printer,Config"\
Comment 1 Rene Engelhard 2011-01-17 14:10:38 UTC
builds fine here,
Comment 2 Rene Engelhard 2011-01-17 14:14:55 UTC
see e.g.https://buildd.debian.org/fetch.cgi?&pkg=libreoffice&ver=1%3A3.3.0~rc3-2&arch=i386&stamp=1295028643&file=log:

[...]
Entering /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/desktop/debian

rm -f /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/libreoffice3.3-debian-menus_*
rm -f -r ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all
dmake ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/control ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/postinst ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/postrm ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/prerm 
ln -sf /opt/libreoffice ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/etc/
/bin/sh -c -x "cd ../../unxlngi6.pro/misc/libreoffice && DESTDIR=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all ICON_PREFIX= KDEMAINDIR=/usr GNOMEDIR=/usr create_tree.sh"
+ cd ../../unxlngi6.pro/misc/libreoffice
+ DESTDIR=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all ICON_PREFIX= KDEMAINDIR=/usr GNOMEDIR=/usr create_tree.sh
Copying icons ..
Copying GNOME icons ..
echo "Package: libreoffice-debian-menus" > ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/control
cat control | tr -d "\015" | sed "s/%productname/LibreOffice/" >> ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/control
echo "Version: 3.3-5" >> ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all/DEBIAN/control
/bin/bash -c "LD_PRELOAD=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/solver/330/unxlngi6.pro/bin/getuid.so dpkg-deb --build ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/libreoffice3.3-debian-menus_3.3-5_all.deb" 
dpkg-deb: building package `libreoffice-debian-menus' in `/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/libreoffice3.3-debian-menus_3.3-5_all.deb'.
rm -f -r ../../unxlngi6.pro/misc/libreoffice3.3-debian-menus_3.3-5_all
rm -f /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/broffice3.3-debian-menus_*
rm -f -r ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all
dmake ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/control ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/postinst ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/postrm ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/prerm 
ln -sf /opt/broffice ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/etc/
/bin/sh -c -x "cd ../../unxlngi6.pro/misc/broffice && DESTDIR=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all ICON_PREFIX= KDEMAINDIR=/usr GNOMEDIR=/usr create_tree.sh"
+ cd ../../unxlngi6.pro/misc/broffice
+ DESTDIR=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all ICON_PREFIX= KDEMAINDIR=/usr GNOMEDIR=/usr create_tree.sh
Copying icons ..
Copying GNOME icons ..
echo "Package: broffice-debian-menus" > ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/control
cat control | tr -d "\015" | sed "s/%productname/BrOffice/" >> ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/control
echo "Version: 3.3-5" >> ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all/DEBIAN/control
/bin/bash -c "LD_PRELOAD=/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/solver/330/unxlngi6.pro/bin/getuid.so dpkg-deb --build ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/broffice3.3-debian-menus_3.3-5_all.deb" 
dpkg-deb: building package `broffice-debian-menus' in `/build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin/desktop-integration/broffice3.3-debian-menus_3.3-5_all.deb'.
rm -f -r ../../unxlngi6.pro/misc/broffice3.3-debian-menus_3.3-5_all

Entering /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/desktop/suse


Entering /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/desktop/util

mkdir -p ../../unxlngi6.pro/bin/deb/
tar -C /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin -cf - desktop-integration/libreoffice3.3-debian-menus_3.3-5_all.deb | gzip > ../../unxlngi6.pro/bin/deb/libreoffice-desktop-integration.tar.gz
mkdir -p ../../unxlngi6.pro/bin/deb/
tar -C /build/buildd-libreoffice_3.3.0~rc3-2-i386-sq66yr/libreoffice-3.3.0~rc3/libreoffice-build/build/libreoffice-3.3.0.3/sysui/unxlngi6.pro/bin -cf - d

[..,]

ok, executed manually with

        # DPKG is only set on with-EPM build what we don't do and the menu stuff
        # is only built wenn DPKG is set.. Same with PKGFORMAT.
        cd $(SOURCE_TREE)/sysui; \
                . $(CURDIR)/$(SOURCE_TREE)/*Env*.sh; \
                PATH=$(BUILD_PATH) DPKG="dpkg" PKGFORMAT="deb" NO_PKG_MANGLE=go-away \
                ../solenv/bin/build.pl && ../solenv/bin/deliver.pl

but that shouldn't matter.... What is your exact error?
Comment 3 Jan de Kruyf 2011-01-17 21:55:50 UTC
Sorry Rene,
Perhaps I was not clear.
On installing the prefab DEBS, Libreoffice does not show up in my menu structure
because debian  'update-menus' (to generate the Debian menu system) does not 
recognize the package name 'libreoffice-. . . ' it wants 'libreoffice3-. . .'
since these are the package names in the distribution.

The printer administration menu item, I do not know to which package to assign without the source, so for the time being I tied it to the Brand module for LibreOffice 3.3.

I feel that the packages should rather appear under 'Office' in the menu structure, at least that is how I interpret the guidelines in the Debian docs.


On the side: I have a problem getting the help package to show from the toolbar.

Libreoffice desparately wants to use KDE which is not installed on my system at this moment. 
So I linked 'kde-open-url' (in /opt/libreoffice/basis3.3/program/) to gnome-open-url in the same dir. That wants to work, but it calls up the web page. I have not found out yet how to get the local file up.

But perhaps this discussion belongs somewhere else. . . .
Thanks for yr quick reply.

Regards

Jan de Kruyf.
Comment 4 Rene Engelhard 2011-01-19 09:18:05 UTC
> Perhaps I was not clear.

Indeed.

> On installing the prefab DEBS, Libreoffice does not show up in my menu
> structure because debian  'update-menus' (to generate the Debian menu system)
> does not recognize the package name 'libreoffice-. . . ' it wants 
> 'libreoffice3-. . .' since these are the package names in the distribution.

No, in  the distribution those package names *are* libreoffice-*, for the TDF
tar, you are right, yes, except that it should be Applications/Office.

See sections 3.2 and 3.5 of the menu manual. (/usr/share/doc/menu/html/ch3.html)

> I feel that the packages should rather appear under 'Office' in the menu
> structure, at least that is how I interpret the guidelines in the Debian docs.

ACK,
Comment 5 Björn Michaelsen 2011-12-23 11:46:14 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 6 sasha.libreoffice 2012-02-23 03:38:56 UTC
In 3.5.0 problem still exist?
Comment 7 Florian Reisinger 2012-08-14 13:59:34 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 8 Florian Reisinger 2012-08-14 14:00:44 UTC Comment hidden (obsolete)
Comment 9 Florian Reisinger 2012-08-14 14:05:27 UTC Comment hidden (obsolete)
Comment 10 Florian Reisinger 2012-08-14 14:07:29 UTC Comment hidden (obsolete)
Comment 11 Commit Notification 2023-12-09 07:18:54 UTC
Sahil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cad62803ba39c560a3e5bc3a51300cc1136b5afd

tdf#33210 Add Listener for ColumnRowHighlighting changes

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-12-10 09:29:54 UTC
Sahil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6e712d5bfaf8b14aacddf903d616447ef22e14f7

tdf#33210 Directly call the method, as it is inherited

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.