Bug 33243 - [SVG Export] Presentation placeholder texts are exported
Summary: [SVG Export] Presentation placeholder texts are exported
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Kurosawa Takeshi
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 06:39 UTC by Kurosawa Takeshi
Modified: 2014-01-24 23:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Original file with presentation placeholders (44.05 KB, application/vnd.oasis.opendocument.presentation)
2011-01-18 06:39 UTC, Kurosawa Takeshi 		Details
Exported SVG which has presentation placeholders (47.30 KB, image/svg+xml)
2011-01-21 16:30 UTC, Kurosawa Takeshi 		Details
Patch (4.88 KB, patch)
2011-01-21 16:38 UTC, Kurosawa Takeshi 		Details
Exported SVG with patch (40.47 KB, image/svg+xml)
2011-01-21 16:39 UTC, Kurosawa Takeshi 		Details
Document to test bug (20.83 KB, application/vnd.oasis.opendocument.presentation)
2013-11-12 02:03 UTC, Stéphane Guillou (stragu) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurosawa Takeshi 2011-01-18 06:39:42 UTC 
Created attachment 42164 [details]
Original file with presentation placeholders

In impress, the SVG export filter exports the presentation placeholder texts of a master page.
However they are invisible in screen and shouldn't be exported.
Comment 1 Kurosawa Takeshi 2011-01-21 16:30:23 UTC 
Created attachment 42294 [details]
Exported SVG which has presentation placeholders

For debugging purpose, the file is indented using xmllint
Comment 2 Kurosawa Takeshi 2011-01-21 16:38:42 UTC 
Created attachment 42296 [details]
Patch

If a shapes is neither a TitleTextPage or an OutlinerShape on a master page, mark it as a hide object.
The code is based on FlashExporter::exportShape.
Comment 3 Kurosawa Takeshi 2011-01-21 16:39:18 UTC 
Created attachment 42297 [details]
Exported SVG with patch

The placeholders are not shown.
Comment 4 Roman Eisele 2012-05-03 08:37:34 UTC 
This is an Impress bug, therefore changed Component accordingly.
Comment 5 Michael Stahl (allotropia) 2012-07-05 06:07:17 UTC 
tbehrens, can you look at this SVG export patch?
Comment 6 ign_christian 2013-06-13 12:05:42 UTC 
Has this bug been fixed?
Comment 7 Stéphane Guillou (stragu) 2013-11-12 02:01:05 UTC 
I witness this bug in 4.1.2.3
I do not get the text when I export to jpg or png, I only get it in svg.
See attachment.
Comment 8 Stéphane Guillou (stragu) 2013-11-12 02:03:34 UTC 
Created attachment 89063 [details]
Document to test bug

Export this document as svg. Text appears behind objects. This does not happen with jpg or png.
The text is invisible in the document, and is not selectable with the navigator or tab key.
Comment 9 ign_christian 2013-11-12 02:05:32 UTC 
How about patch in comment 3 ? Perhaps that's been reviewed?
Comment 10 Thorsten Behrens (allotropia) 2013-11-16 00:29:58 UTC 
Patch lifted on current code base & committed. Example docs look fine now -> fixed. Thanks a lot for the patch!
Comment 11 Commit Notification 2013-11-16 00:38:14 UTC 
Kurosawa Takeshi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=be7c599a125df6946c1b5a1233cda27740081273

fdo#33243 Fix SVG export presentation placeholder texts exported



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Stéphane Guillou (stragu) 2014-01-24 23:09:16 UTC 
This is still happening in 4.1.5 RC1. Is there any plans to add the patch for 4.1.6 or is it too dangerous?