Bug 34431 - [PATCH]More symbols (crosses, circles) needed for data points in charts
Summary: [PATCH]More symbols (crosses, circles) needed for data points in charts
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
(earliest affected)
3.3.0 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
Depends on: 40466
  Show dependency treegraph
Reported: 2011-02-18 02:20 UTC by nicotnc-gecko
Modified: 2011-12-23 11:58 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

See Comment 1 (23.37 KB, application/vnd.oasis.opendocument.spreadsheet)
2011-02-20 23:13 UTC, Rainer Bielefeld Retired
Additional data series markers proposals (14.13 KB, application/vnd.oasis.opendocument.graphics)
2011-02-21 05:12 UTC, nicotnc-gecko
Add new standard symbols for data points (28.99 KB, patch)
2011-08-30 13:46 UTC, Regina Henschel
Some mappings changed (3.71 KB, patch)
2011-08-30 13:49 UTC, Regina Henschel
Add missing chart data point ODF1.2 standard symbols (29.67 KB, patch)
2011-09-09 06:14 UTC, Regina Henschel

Note You need to log in before you can comment on or make changes to this bug.
Description nicotnc-gecko 2011-02-18 02:20:26 UTC
The eight built-in symbols for charts are not sufficient for some (many?) users. Crosses (+, x) and circles are for instance needed for scientific (and education) uses.

Related OOo bug (with 12 votes): http://www.openoffice.org/issues/show_bug.cgi?id=3582
Comment 1 Rainer Bielefeld Retired 2011-02-20 22:27:55 UTC
You can simply add required symbols to gallery and use it them, what's wrong with that possibility?
May be an Extension "add scientific chart line symbols" might be useful?
Comment 2 Rainer Bielefeld Retired 2011-02-20 23:13:22 UTC
Created attachment 43586 [details]
See Comment 1
Comment 3 nicotnc-gecko 2011-02-20 23:40:49 UTC
Actually, at home I could open a svg image editor, create the symbol I need, save it and add it to the gallery, but many users don't have time do to this, or not the ability (either they are not advanced users enough, either they just don't have any svg editor, for instance at work).

This seems to me a blocking factor to introduction in companies or education. I remember being asked a few years ago by my high school chemistry teacher to use Excel instead of OOo during practical works because the first one could make charts with crosses, and ooo not.

Therefore, having at least the same symbols as in Excel would be more that useful. But an extension to do so risks to be useful only to those who already can make their SVG symbols.
Comment 4 Rainer Bielefeld Retired 2011-02-21 04:25:24 UTC
If you could attach here a DRAW document containing Symbols in accordance to your needs, it should be an ease hack to make these symbols available as Chart symbols.
May be you first do a draft with may be 5 symbols, if that works, we can create a complete set.
Comment 5 nicotnc-gecko 2011-02-21 05:12:58 UTC
Created attachment 43597 [details]
Additional data series markers proposals

Here are 5 proposals, with "+" and "x" crosses, full and empty circle and empty square.

I don't have any computer with MS Excel to check the available symbols, but I think that these 5 are enough.
Comment 6 Rainer Bielefeld Retired 2011-02-26 01:39:18 UTC
What does " ... needed for scientific (andeducation) uses." mean? What scientific conventions arrogate use of "X" instead of a mutton in a chart line?

My gallery proposal has the disadvantage that those symbols will not follow line's color.
Comment 7 Rainer Bielefeld Retired 2011-02-26 03:33:57 UTC
May be a solution could be to use characters for additional symbols? They can use the same colors as lines, it should not be too difficult to "connect" their color to the one of the line. Remains the "ad hoc to picture conversion" for the use as symbol, what might not be an "easy hack".
Comment 8 Cédric Bosdonnat 2011-03-03 01:35:17 UTC
kohei, could you help giving some pointers to make this an easy hack?

Not sure, but maybe this can help: 
Comment 9 Regina Henschel 2011-07-09 16:29:21 UTC
In ODF1.2 more symbols are defined. They include Circle, X and Plus. So those symbols can be stored in file format.

To get filled and unfilled circle and square it is necessary to allow to set the border and the filling of the symbols independent from each other.

The corresponding issues in OOo are 3582, 117838 and 64728.

If it is not urgent, I would like to work on this issue.
Comment 10 Regina Henschel 2011-08-30 13:43:47 UTC
I have made a prototype implementation for additional symbols. That are those symbols which are listed as "named symbols" in the ODF1.2 specification.

Non-filled symbols are not contained, because currently it is not possible to set border and filling independently in LibO.

You find pictures of the new symbols in

I will attach two patches in addition, so that you can examine the code. The patches are not full tested yet, so please do not push them immediately.
Comment 11 Regina Henschel 2011-08-30 13:46:39 UTC
Created attachment 50702 [details]
Add new standard symbols for data points
Comment 12 Regina Henschel 2011-08-30 13:49:47 UTC
Created attachment 50704 [details]
Some mappings changed

I have altered some mappings, so that 'circle' is only used for circle, and right arrow is mapped to Excels 'DOWJ' for import and export.
Comment 13 Regina Henschel 2011-09-09 06:14:18 UTC
Created attachment 50999 [details]
Add missing chart data point ODF1.2 standard symbols

Final patch, now in one file :)

Following problems are already in current LibO version and not caused by my patch:
*Import of xls looses values of non-automatic fields
*Import of xlsx sets the kind to "automatic" although they were explicitly set in Excel
*Export to xlsx sets the kind to "automatic" although they are explicitly set in LibO.
Comment 14 Kohei Yoshida 2011-09-20 09:30:10 UTC
I've pushed Regina's patch to master, which should add more stock symbol types and save and load with ODS file format.

We still need to take care of mapping with the xls(x) file formats, but we could make that a separate bug if needed (so that we can close this one).
Comment 15 Björn Michaelsen 2011-12-23 11:47:25 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 16 Regina Henschel 2011-12-23 11:56:28 UTC
I see the new symbols in LO3.5Beta1.
Comment 17 Regina Henschel 2011-12-23 11:57:33 UTC
Closing. Please file a new issue, if you see further problems with markers in charts.
Comment 18 Regina Henschel 2011-12-23 11:58:12 UTC
remove keywords