Bug 35406 - simplify lcl_GetRelativePos
Summary: simplify lcl_GetRelativePos
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Kohei Yoshida
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 01:53 UTC by Caolán McNamara
Modified: 2011-03-18 08:41 UTC (History)
0 users

See Also:
Crash report or crash signature:

Attachments
like so (1.39 KB, application/octet-stream)
2011-03-18 01:53 UTC, Caolán McNamara 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2011-03-18 01:53:42 UTC 
Created attachment 44568 [details]
like so

In sc/source/ui/unoobj/shapeuno.cxx we have a
ScRange aRange = ... where aRange is then unused, it seems the entire line doesn't do anything, which leaves a symmetrical expression that can be simplified a bit, as attached.
Comment 1 Kohei Yoshida 2011-03-18 07:51:01 UTC 
Yup, the patch makes sense, and it's a lot simpler.

I've committed it locally, and as soon as kendy is done merging the integration/dev300_m101 branch onto master I'll push.
Comment 2 Kohei Yoshida 2011-03-18 08:41:19 UTC 
Merging is done.  Pushed to master.