Bug 36439 - Find Toolbar won't close if left open
Summary: Find Toolbar won't close if left open
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.4.0 Beta2
Hardware: Other All
: medium minor
Assignee: Jan Holesovsky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 15:57 UTC by Zack
Modified: 2013-01-18 21:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
How toolbar looks open (171.82 KB, image/png)
2011-04-20 15:59 UTC, Zack
Details
Toolbar closed with ugly bar left (179.80 KB, image/png)
2011-04-20 16:00 UTC, Zack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zack 2011-04-20 15:57:56 UTC
If the newly redesigned find toolbar is left open on program close, the next time LO is opened the find toolbar is present and pressing Esc won't close it.

Steps to reproduce:
1. Start writer
2. Use Ctrl+f to open the new find toolbar at the bottom of the screen (pressing Esc will close the toolbar) but leave it open
3. Close LibreOffice (including quickstarter if that's enabled) making sure the Find toolbar is left OPEN
4. Open a new document in writer
5. The find toolbar is open and pressing Esc will NOT close the toolbar.

Using the Close Toolbar button on the toolbar dropdown hides the contents of the toolbar but the bar is still there rather annoyingly occupying a good inch of screen space (I am including a screen shot of this condition).  The only way to get rid of the toolbar in this instance is to click close toolbar, press Ctrl+f to reopen it, and then Esc will work to close the toolbar.
Comment 1 Zack 2011-04-20 15:59:22 UTC
Created attachment 45879 [details]
How toolbar looks open

This screenshot is of the new Find toolbar and how it looks open.  The dropdown is expanded and I'm about to click Close Toolbar.  The next screenshot shows what is left after closing the toolbar.
Comment 2 Zack 2011-04-20 16:00:52 UTC
Created attachment 45880 [details]
Toolbar closed with ugly bar left

This is how the Find toolbar looks after it has been closed using the button (the only way to 'close' it if the toolbar was left open).  As you can see, the contents disappear, but the bar remains.  I circled the bar in Red.
Comment 3 Zack 2011-04-20 16:16:32 UTC
Looking at the 3.4 release notes it looks like you helped in creating this improvement.  Mind taking a look Jan?
Comment 4 manj_k 2011-04-21 06:47:03 UTC
[Zack]
"This is how the Find toolbar looks after it has been closed using the button
(the only way to 'close' it if the toolbar was left open).  As you can see, the
contents disappear, but the bar remains."

Setting the focus (cursor) into the "find toolbar" will close "the whole thingy" with Esc, as expected.

INVALID?
Comment 5 Zack 2011-04-21 09:30:31 UTC
(In reply to comment #4)
> [Zack]
> "This is how the Find toolbar looks after it has been closed using the button
> (the only way to 'close' it if the toolbar was left open).  As you can see, the
> contents disappear, but the bar remains."
> 
> Setting the focus (cursor) into the "find toolbar" will close "the whole
> thingy" with Esc, as expected.
> 
> INVALID?

Ok if I click the find text box after the toolbar has been left open you're right, clicking escape will then close the toolbar.  But I don't think the toolbar should be left open between closing the program and reopening.  Firefox does not behave this way (which is what this feature is modeled after) and neither does Chrome.

Clicking 'close toolbar' does not close the toolbar either, which is certainly a bug.
Comment 6 manj_k 2011-04-21 09:45:45 UTC
Yep, I agree with this point of view.
I have misunderstood your issue, my mistake, sorry.
Comment 7 Zack 2011-04-25 13:27:15 UTC
Changing component to Libreoffice as this affects all the components of LO, not just writer.
Comment 8 Rainer Bielefeld Retired 2011-04-30 11:07:18 UTC
Compared to the other toolbar problems, especially 
Bug 36571 - Find bar does not appear properly at top of screen
This is a minor one, I don't see it as a "most annoying one".
Comment 9 Rainer Bielefeld Retired 2011-05-05 22:26:32 UTC
Removed from "Most Annoying".

@Kohei:
Can you please check?
Comment 10 Kohei Yoshida 2011-05-05 22:53:48 UTC
There is a duplicate for this filed somewhere.
Comment 11 Kohei Yoshida 2011-05-05 22:54:41 UTC
And I remember I assigned the original bug to kendy.  I'll do the same for this one.
Comment 12 Patrick Scott 2011-06-12 07:39:27 UTC
Should we also be considering adding a X button to the find toolbar? The find toolbar is modeled after Firefox and Chrome and both of those browsers display a graphical close button in the toolbar. Pressing the 'Esc' key is not really discoverabl, I only found out about that shortcut when reading this bug report. IMO shortcut keys should only ever act as a secondary method of doing something, and not the primary method.
Comment 13 Cor Nouws 2013-01-18 21:25:23 UTC
Hi Joren, *
IN 4.0.0RC1
 - Writer
 - Ctrl-F
 - Click in Document
 - Close LibreOffice
 - Restart
 - Writer document
 - Ctrl+F (focus in Find bar)
 - Esc >> Find bar closes...
So looks OK, anyway on my Linux Ubuntu 12.10 32 bits
Comment 14 Jorendc 2013-01-18 21:35:04 UTC
(In reply to comment #13)
> Hi Joren, *
> IN 4.0.0RC1
>  - Writer
>  - Ctrl-F
>  - Click in Document
>  - Close LibreOffice
>  - Restart
>  - Writer document
>  - Ctrl+F (focus in Find bar)
>  - Esc >> Find bar closes...
> So looks OK, anyway on my Linux Ubuntu 12.10 32 bits

I agree with that, and Bug 58526 and Bug 59101 this'll be fixed (you also can use ctrl+F to toggle).

Tested with ubuntu 12.10 x64; Can't reproduce bug anymore -> RESOLVED WORKSFORME