Platform: SLED 11 sp1 i586
build info: Libreoffice 3.4 beta5
1. Launch Calc
2. Select some cells
3. Right click the mouse and select 'Format Cells...' in the context menu
4. Switch to 'Border' tab
5. Select in the 'Default' section: 'Set Outer border and All Inner Lines'
6. Select in the 'Style' section: Dash border
7. Set in the 'Width' field: 0.25pt
8. Press OK
The border lines of the cells were drawn but in solid style. It is
expected selected dash/dotted borders were drawn.
- This is a regression problem against 3.3
- attached SCREENSHOT: When set the Width longer (1.5pt for example),
the border looks abnormal.
- The problem also happens in the Writer table, but looks drawn well in
table of Presentation.
For Kohei's review, thank you!
Same problem with tables in Writer. Keywords regression.
borders bugs are mine
Created attachment 46625 [details]
After some investigations, it appears that this is coming from the very small size of the line.
The result is correct on printing/exporting in PDF, but it's wrong on screen. This behavior gives to user a very bad feedback.
Temporarily, how about reverting a part of the patches?
I'm guessing that this problem occurs because of the following commit.
"Use svx:: frame:: DrawRange with the drawinglayer in calc now"
Because in Calc, this problem is solved in the following modifications.
----- here -----
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
@@ -1232,7 +1232,7 @@ void ScOutputData::DrawFrame()
size_t nRow2 = nRow1;
while( (nRow2 + 1 <= nLastRow) && pRowInfo[ nRow2 + 1 ].bChanged ) ++nRow2;
- rArray.DrawRange( pProcessor, nFirstCol, nRow1, nLastCol, nRow2, pForceColor );
+ rArray.DrawRange( *pDev, nFirstCol, nRow1, nLastCol, nRow2, pForceColor );
nRow1 = nRow2 + 1;
----- now -----
(In reply to comment #7)
> Temporarily, how about reverting a part of the patches?
> - rArray.DrawRange( pProcessor, nFirstCol, nRow1, nLastCol, nRow2,
> pForceColor );
> + rArray.DrawRange( *pDev, nFirstCol, nRow1, nLastCol, nRow2,
> pForceColor );
Surely not revert that part of the patch or you'll loose all the benefits of the new borders in Calc.
What should be done is to make a better decomposition for the border2DPrimitive when it comes to dots and dashes... but the troubles comes from the different zoom levels possible.
Same problem with Writer 3.4.2 on Windows XP
If I click-right on the table and choose Table option in menu, it's impossible to choose dotted border, for example. Only plain or none works.
But if I use the toolbox wich appears when I click on the table, it works.
The problem doesn't appears with LibreOffice 3.3.2 and 3.3.3.
(In reply to comment #9)
> Same problem with Writer 3.4.2 on Windows XP
> If I click-right on the table and choose Table option in menu, it's impossible
> to choose dotted border, for example. Only plain or none works.
> But if I use the toolbox wich appears when I click on the table, it works.
> The problem doesn't appears with LibreOffice 3.3.2 and 3.3.3.
Same problem with 3.4.3 in Linux x86_64 (debian squeeze).
Please, don't change version!
Fixed by this commit in master:
Many thanks for the patch!
I noticed that with this bug fix the dashed/dotted borders' snippets don't change their size while zooming. That makes snippets to be bigger compared to the content when zoom level is lower and to be smaller compared to the content in case of upper zoom level.
The root of the problem is that the pattern which used to construct dashed line is constant and so doesn't change with zoom level as it would be expected (See ctrlbox.cxx:GetDashing()) method).