Bug 37889 - Adapt smoothing with splines to ODF1.2
Summary: Adapt smoothing with splines to ODF1.2
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: x86 (IA32) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 12:12 UTC by Regina Henschel
Modified: 2011-06-10 02:57 UTC (History)
0 users

See Also:
Crash report or crash signature:

Attachments
patch for Splines.cxx against LO 3.4.0.2 (38.47 KB, patch)
2011-06-03 12:12 UTC, Regina Henschel 		Details
patch for Splines.hxx against LO 3.4.0.2 (750 bytes, patch)
2011-06-03 12:13 UTC, Regina Henschel 		Details
complete new Splines.cxx for better reading (36.66 KB, text/plain)
2011-06-03 12:16 UTC, Regina Henschel 		Details
A collection of files with charts for testing. (442.34 KB, application/x-zip-compressed)
2011-06-03 13:57 UTC, Regina Henschel 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2011-06-03 12:12:41 UTC 
Created attachment 47488 [details]
patch for Splines.cxx against LO 3.4.0.2

In ODF 1.2 [1] smoothing with splines is concretized. The spec now contains a detailed description, how this splines have to be calculated. The attached patches implement this algorithms. The patches are against LO3.4.0.2

This changes are large, therefore I'll attach the file itself too, so that reading is easier. The solution is tested on WinXp, but need exhaustive testing on other platforms, especially 64bit versions.

[1] http://docs.oasis-open.org/office/v1.2/OpenDocument-v1.2-part1.odt
Comment 1 Regina Henschel 2011-06-03 12:13:57 UTC 
Created attachment 47489 [details]
patch for Splines.hxx against LO 3.4.0.2
Comment 2 Regina Henschel 2011-06-03 12:16:32 UTC 
Created attachment 47490 [details]
complete new Splines.cxx for better reading
Comment 3 Regina Henschel 2011-06-03 13:57:21 UTC 
Created attachment 47491 [details]
A collection of files with charts for testing.
Comment 4 Fridrich Strba 2011-06-06 11:56:02 UTC 
I committed the two patches as commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f18c69f3f40bf443b59bd006db220267ba5174d0 into LibreOffice master.
Comment 5 Rainer Bielefeld Retired 2011-06-10 02:57:51 UTC 
RC2 is bit by bit identical with release version, so separate items in the version picker are useless. Changes have been discussed with Michael Meeks.