Bug 37947 - Unstable named ranges on sheet level
Summary: Unstable named ranges on sheet level
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: All Linux (All)
: medium normal
Assignee: Kohei Yoshida
URL:
Whiteboard: target:3.4.1
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-05 04:11 UTC by Andreas Säger
Modified: 2011-06-10 02:57 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
ODF spreadsheet created with LibO3.4 using the new naming scheme on sheet level (17.35 KB, application/vnd.oasis.opendocument.spreadsheet)
2011-06-05 04:13 UTC, Andreas Säger
Details
much simpler test document (7.29 KB, application/vnd.oasis.opendocument.spreadsheet)
2011-06-07 18:33 UTC, Kohei Yoshida
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Säger 2011-06-05 04:11:21 UTC
Testing the new names on sheet level, I stumbled upon several problems. I'll attach my test file with 5 names and some comments on the first sheet.
One pair of names seems to cause trouble: Sheet1.MyNamed refers to Sheet2 and Sheet2.MyNamed refers to Sheet1 without intersection/circular ref. Sheet1.MyRef turns into an invalid external reference after reloading the file.
Comment 1 Andreas Säger 2011-06-05 04:13:29 UTC
Created attachment 47551 [details]
ODF spreadsheet created with LibO3.4 using the new naming scheme on sheet level
Comment 2 Oliver Brinzing 2011-06-05 07:33:30 UTC
.
Comment 3 Markus Mohrhard 2011-06-06 20:49:31 UTC
I have a look at it
Comment 4 Markus Mohrhard 2011-06-07 00:58:22 UTC
Ok, I found the problem, but I'm not sure if I will include this into 3.4.1.

It seems the change for this will be bigger than I expected.
Comment 5 Kohei Yoshida 2011-06-07 18:33:02 UTC
Created attachment 47697 [details]
much simpler test document
Comment 6 Kohei Yoshida 2011-06-07 18:54:41 UTC
So, as Markus and I discussed on IRC, this is a bit tricky problem.  Let me look into this to see if there is a easy way to solve this....
Comment 7 Kohei Yoshida 2011-06-07 21:26:01 UTC
Ok.  I fixed it.  The problem was the import filter incorrectly imported a sheet-local named range that references another sheet as an external reference, and with my fix they are now correctly imported.

But your attached document is already messed up i.e. MyNamed on Sheet1 is already stored as an external reference.  So, you need to remove that, and re-define it once my fix is in.
Comment 8 Kohei Yoshida 2011-06-07 21:39:52 UTC
Marked it fixed for 3.5.  Sent it to the mailing list for review for 3.4.1.
Comment 9 Kohei Yoshida 2011-06-08 16:00:35 UTC
I got Markus' sign-off.  The fix will be in 3.4.1.
Comment 10 Rainer Bielefeld Retired 2011-06-10 02:57:24 UTC
RC2 is bit by bit identical with release version, so separate items in the version picker are useless. Changes have been discussed with Michael Meeks.