Bug 38177 - Closing parent Base window leaves wizard generated table, query, report or form window in orphaned state
Summary: Closing parent Base window leaves wizard generated table, query, report or fo...
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: Other All
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: mab3.4
  Show dependency treegraph
 
Reported: 2011-06-11 00:05 UTC by Alex Thurgood
Modified: 2012-01-23 04:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
test db file (193.96 KB, application/vnd.oasis.opendocument.database)
2011-06-11 00:06 UTC, Alex Thurgood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2011-06-11 00:05:47 UTC
1) Open an existing Base file containing data.
2) Start one of the wizards, e.g. the form wizard. A child window opens with the wizard dialog.
3) Step through the wizard until you get to the Form naming step.
4) Now close the main Base window.

What actually happens :
The Form child window becomes orphaned, and the wizard dialog no longer allows the user to proceed to the end of the wizard. All the user can now do is click on cancel. However, there are no messages or any other signs that he/she is now disconnected from the Base.


What should happen :
(a) it should not be possible to dispose of the main connection until the child has completed
(b) the user should receive a warning that closing the main Base window will cause data loss (the as yet unsaved changes).

Adding test ODB file.


Alex
Comment 1 Alex Thurgood 2011-06-11 00:06:47 UTC
Created attachment 47840 [details]
test db file
Comment 2 ribotb 2011-07-12 01:00:16 UTC
Hi Alex,

I reproduce with LibO 3.4.1 on Windows 7.

Bernard
Comment 3 Alex Thurgood 2011-09-26 09:40:35 UTC
Nominating as a blocker, upping criticality due to data loss.


Alex
Comment 4 Cor Nouws 2011-09-26 13:13:58 UTC
(In reply to comment #0)
> 1) Open an existing Base file containing data.

Hi Alex,
Did you find this first on a 3.4.0 version?
Comment 5 ribotb 2011-09-27 00:03:56 UTC
Hello,

The problem is still present in LO 3.4.3

Bernard
Comment 6 Alex Thurgood 2011-09-28 00:08:23 UTC
(In reply to comment #4)

> Hi Alex,
> Did you find this first on a 3.4.0 version?

Hi Cor,

Yes, but I didn't flag it as a blocker at the time because it seemed that Base bugs weren't being considered serious enough to warrant being blockers (I'm still not entirely convinced they are given due regard even today, but that is just my personal opinion).

Alex
Comment 7 Julien Nabet 2011-10-26 14:58:49 UTC
I can reproduce the pb too on 3.4.3 (pc Debian x86-32).
But I don't reproduce it in master branch (future 3.5).

I don't know if there has been put on 3.4 branch. I'm retrieving the 3.4 repo.
Then I must compile, I should tell if I can reproduce this on 3.4.4 or 3.4.X (last sources on 3.4) by tomorrow and the next day.
Comment 8 Julien Nabet 2011-10-26 23:45:25 UTC
I had an error compiling 3.4.4 just after having downloaded all the sources.
Also, I haven't succeeded in using the pre-releases http://dev-builds.libreoffice.org/pre-releases/ 
Perhaps someone will more lucky than me. 

According to the release plan (http://wiki.documentfoundation.org/ReleasePlan), 3.4.4 will be released the 09/11.
Comment 9 Julien Nabet 2011-10-30 02:58:24 UTC
ribotb: on which platform (x86-32, x86-64/AMD, other ?) and which environment (Windows, Linux, Mac) have you reproduced this pb ? Which version of Java do you use ?

Alex: do you reproduce this on 3.4.3 ? Have you got error messages, backtrace or something ?

Thanks in advance to both of you for information you could bring.
Comment 10 Alex Thurgood 2011-10-30 03:08:58 UTC
(In reply to comment #9)

> 
> Alex: do you reproduce this on 3.4.3 ? Have you got error messages, backtrace
> or something ?
> 
> Thanks in advance to both of you for information you could bring.

Hi Julien,
I noticed this on Mac OSX with LO 3.4.3. Haven't tried with a 3.5 build yet. I don't recall there being a backtrace because I had to force kill the app.


Alex
Comment 11 ribotb 2011-10-30 04:17:49 UTC
To Julien Nabet :

platform x86 32 bits
OS : Windows 7 SP1
Java : JRE 6.23
Comment 12 Julien Nabet 2011-11-13 13:53:39 UTC
I reproduced this pb with 3.4.4.:-( (Debian SID packages of LO installed on testing Debian)
Comment 13 Björn Michaelsen 2011-12-23 12:23:56 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 14 Björn Michaelsen 2011-12-23 17:01:12 UTC
needinfo keyword redundant by needinfo status.
Comment 15 Rainer Bielefeld Retired 2011-12-24 00:18:55 UTC
I can't see any NEEDINFO reason.

@Lionel:
Please feel free to reassign (or reset Assignee to default) if it’s not your area or if provided information is not sufficient. Please set Status to ASSIGNED if you accept this Bug.
Comment 16 Julien Nabet 2011-12-27 02:07:44 UTC
Alex: I didn't reproduce this problem on master (future 3.6) and 3.5 branch.
In both case, if I click on the cross to close the main window, it does nothing, so no orphan windows.
(PC Debian x86-64).
Could you try again with 3.5.0 beta2 ?
Comment 17 Lionel Elie Mamane 2012-01-23 03:32:47 UTC
This is more GUI-related than "database stuff", so I'll say "not my area" -> resetting assignee to default.

I confirm that this seems fixed in 3.5.

Personally, I don't see this as a very annoying bug, because the actions leading to triggering the bug are not ones the user would naturally do; they are a bit contrived. it is like in writer "I open the search/replace dialog, then close the document, the search/replace dialog does not work anymore". It is a bug, it is embarassing in that it shows "bad code/design/... quality", but not high severity overall.

For all I'm concerned, we can close this as "fixed in 3.5"; if somebody wants to hunt down what fixed it in 3.5 and backport to 3.4, that's nice. I'll even review the patch if it is sent it to me.
Comment 18 Alex Thurgood 2012-01-23 04:33:08 UTC
(In reply to comment #17)

Hi Lionel,

> 
> I confirm that this seems fixed in 3.5.
> 
> 
> For all I'm concerned, we can close this as "fixed in 3.5"; if somebody wants
> to hunt down what fixed it in 3.5 and backport to 3.4, that's nice. I'll even
> review the patch if it is sent it to me.


Confirming fixed on 3.5 RC1 on Mac OSX too.
Closing as resolved fixed.

Alex