==== write tools/ pieces out ==== '''Background:''' tools is a library packed full of deprecated code, that has equivalents in sal/ (the system abstraction layer). Of course the sal/ versions are often less usable than the tools/ version, so some API improvements may be required on the way too. A good place to start might be to audit and remove all uses of: tools/source/fsys/dirent.cxx - and associated types, in favour of (and while improving) sal/inc/osl/file.hxx osl::Directory etc. This should (most likely) be done a module / call site at a time. Se status for sc on [[Easy Hacks - Remove tools - calc]] '''Skills:''' building, simple C++ programming, test
Another good one is tools/stack with the stl stack. To find places where tools/stack is included: http://opengrok.libreoffice.org/search?q=tools%2Fstack&project=core&defs=&refs=&path=&hist=
Note that for tools' container types there's a separate EasyHack bug 38832.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=de99bcde8a66a410287c7fb9c4ae6d6c9b7f05a6 fdo#39445 writing out tools/fsys.hxx The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd49ebe1aab8c2d05243f7ac96183fb77ea0a819 fdo#39445 writing out tools/fsys.hxx (basic) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=768dee2c32d4da440f1f05c70beb8f668b1364a1 fdo#39445 writing out tools/fsys.hxx (rsc) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0173e89ca254a18953615c07864d1da22e5149b5 fdo#39445 writing out tools/fsys.hxx (sot) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=438efb38ec42f9c342342925236cf8ea1eada9fc fdo#39445 writing out tools/fsys.hxx (basic) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=332a93435fc5757532d0b93b38aaf9fe1c9ca0f5 fdo#39445 writing out tools/fsys.hxx (linguistic) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Krisztian Pinter committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eec2eb05a22966de319ecf370b0c880d7b83a79a fdo#39445 writing out tools/fsys.hxx (idl) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fee08758d149b6d681952c3ac95e195da7cfa6bc fdo#39445 writing out tools/fsys.hxx (rsc) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=91aaceb7275fe8aa163629646de4c3dc7c1c02b3 fdo#39445 writing out tools/fsys.hxx (forms) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tools/fsys.hxx is not used anywhere outside of tools/ itself. tools/stack.hxx was fully removed. I think this bug should be marked as fixed. I don't like open-ended problems, like this "write tools/ pieces out" - what pieces, when can we say we are done etc. Let's open new bugs for the remaining cleanup tasks.
> I think this bug should be marked as fixed. Agreed - thanks for that - I filed another tools/ cleanup easy-hack around solar.h bug#63154 to continue the work. Nice work.
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp ) [NinjaEdit]