=== copy/paste code detector / fixing === '''Background:''' There is a large amount of copy/paste/optional-rename coding going on in the LibreOffice code-base. This creates a maintenance disaster, bigger, slower code, etc. We should find a good cut/paste detector and run it over the code, and fix the output. There are a few known big chunks of code, perhaps more can be added here eg. tools/source/fsys/tempfile.cxx vs. unotools/source/ucbhelper/tempfile.cxx - cf. CreateTemplName_Impl vs. filter/source/placeware/tempfile.cxx etc. A good copy and paste detector is [http://www.harukizaemon.com/simian/ Simian]. The use is free for non-commercial projects. To get a space separated list of .cxx files in a directory, run: find <directory> -name "*.cxx" | grep -v unxlng | tr '\n' ' ' > files The Simian call to get code pieces with at least 30 equivalent lines is for example: java -jar simian-2.3.31.jar -threshold=30 -language=c++ `cat files` '''Skills:''' building, basic C++
Deteted "Easyhack" from summary
Created attachment 78635 [details] Removes duplicate code from sc/source/ui/view/output2.cxx Hi, Possibly removes copy/paste code from the output2.cxx. I have refactored duplicated code into several methods. It's my first patch for LO Project. So any criticism is welcome :) Regards, Minh
Great to see your work Minh - I'll try to get to reviewing it, but Markus might get there faster (not sure :-).
Will look into the patch later.
Wow - this looks really nice Minh - good work there ! it's great to see duplicate code dying ... Just build testing before pushing to master; the code looks correct just reading it.
Minh Ngo committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca8b63523885c89c694799622c319260346b00f6 fdo#39593 - share copy/paste code, and add a few consts. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I have been bugging this bug, and pushed two patches to gerrit. But now I am stuck and need some guidance. I have found that these files are quiet similiar and I am uncertain how I can fix it. Between lines 213 and 528 in /home/jelle/media/core/connectivity/source/drivers/mozab/MPreparedStatement.cxx Between lines 212 and 527 in /home/jelle/media/core/connectivity/source/drivers/mork/MPreparedStatement.cxx Found 278 duplicate lines in the following files: Between lines 301 and 938 in /home/jelle/media/core/connectivity/source/drivers/mozab/MDatabaseMetaData.cxx Between lines 296 and 933 in /home/jelle/media/core/connectivity/source/drivers/mork/MDatabaseMetaData.cxx Found 305 duplicate lines in the following files: Between lines 584 and 1092 in /home/jelle/media/core/connectivity/source/drivers/mork/MResultSet.cxx Between lines 569 and 1077 in /home/jelle/media/core/connectivity/source/drivers/mozab/MResultSet.cxx
Also the class in these files is identical. Not sure how to fix this either. sd/source/ui/toolpanel/controls/MasterPageContainer.cxx sd/source/ui/sidebar/MasterPageContainer.cxx
Hi Jelle, the sidebar and toolpanel duplication is expected, I guess eventually we will remove one or the other - but that will be under development for 4.2 so ... I'd skip that for now :-) Similarly the mozab code is scheduled for destruction as/when we have some final pieces finished on windows we can drop it there - which we're looking forward to but - it still requires some work. So - good catches ! but I'd avoid those two areas :-)
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=07cd857a0e35c9f80f35e8c042ff0ae16aceaef7 fdo#39593 remove unused function 'checkBitmapImport' and clean up code The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Those are nearly identical, too: oox/source/export/ColorPropertySet.cxx xmloff/source/chart/ColorPropertySet.cxx oox/source/export/ColorPropertySet.hxx xmloff/source/chart/ColorPropertySet.hxx
Comment on attachment 78635 [details] Removes duplicate code from sc/source/ui/view/output2.cxx patch found integrated as ca8b63523885c89c694799622c319260346b00f6 setting "obsolete" flag so it does not show up in bugzilla queries.
Back to NEW as changing of the status is unclear and I don't see any request in comments for additional information. @gandhishrey@gmail.com: you are the current Assignee - are you working on it? If not please reset to default Assignee.
Created attachment 100719 [details] Clones found with CCFinderX I found code clones using CCFinderX(https://github.com/petersenna/ccfinderx-core). I was looking for big blocks of code, so I used the options: $ ./ccfx/ccfx d cpp -k- -w f+g+ -b 500 -t 20 -d /var/tmp/libreoffice/core What should I do next? Are you interested in clones that are smaller blocks of code? Are those clones the kind of issue this bug is about?
Peter, this sounds promising. But all files inside workdir/ and instdir/ are just files which are used and generated at compile time. You can omit all of them. The */qa/* dirs could also be omitted, those are testing code, which is generally a kind of copy and paste. The results for sc/source/core/opencl/op_financial.cxx look good. Yeah, maybe you have to search for smaller chunks. Is there any option to output the results as html report, like cppcheck does (sorry, I didn't look into CCFinderX)? If yes, we could easily upload the reports and fill an EasyHack, so new developers can solve those issues. You could fix them, too, if you like :)
Created attachment 100734 [details] Code clones found with CCFinderX Code clones found with CCFinderX without compile time additional source code, and without */qa/* directories. This was generated for detecting smaller chunks. The command line: $ ./ccfx/ccfx d cpp -k- -b 250 -t 20 -d /tmp/core/ @thomas-libo@arnhold.org I think it is not difficult to generate html from xml. I'm detecting the clones exactly to find something to fix. Which ones should I start with?
Peter, here are some promising examples: clone ids 8831, 8589 and 8468 look like candidates to split them out inside a helper function. Looks like searching for clones which are inside different files is a good starting point. Here are some examples how to fix copy and paste code: 288f0029c69ab0532165877637a146f774d5e740 and http://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=copypasta
Adding self to CC if not already on
See bug #89267 for a specific, easy, already found case of copy-paste orgy.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp ) [NinjaEdit]
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
qarkai committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b12823aa81003e80372bd89db79bd6ba8e032a95 tdf#39593 move duplicate code to separate method It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Is the bug settled ?
I suspect there is a lot more to do =) It would be good to have more up-to-date output of Simian / CCFinderX or whatever to locate duplicate code ... Thanks.
Noel pointed out this tool: https://pmd.github.io/pmd-5.5.5/usage/cpd-usage.html
I am new to LO. Just want to ask if this issue is still open.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0ebba3d8855fee0bcec04a10137ae3a4f9f0e77 tdf#39593 deduplicate code in ExplicitValueProvider It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f34bec2a7b939e24c3c5e884fdfe2057b732248 tdf#39593 deduplicate code in ScOutputData It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=95da9d4c8f320d865939ef2cea268ad1aac20a8e Follow our naming conventions, tdf#39593 follow-up It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca2bc4b6d8fb10b2b9d7bf9646b1be22be88e2ef tdf#39593 deduplicate code in ScOutputData It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=45d6b9aa1986c5e68e7bf03d995bc1f8cd1bc817 Address some nitpicks, tdf#39593 follow-up It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eafc42a2b46e70a0840a870b8c8cce85b32980c1 tdf#39593 deduplicate code in ScOutputData It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5fe3117e1877fa0bfb55f1cf22cf9394b3f0795 tdf#39593 deduplicate code in ScCellShell It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e76bdaeb300e8420a8bc96e5e38b858821d22564 tdf#39593 deduplicate code in ScCellShell It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=22dc2e5cd3e06e12f08dbb86df2df86860d301d6 tdf#39593 deduplicate code in ScCellShell It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hrishabh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f17a04df424dac553195c1922a4e4aa1f4ad5b9d tdf#39593 fixed copy paste code in sw edlingu.cxx It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I wish to work on this bug.
I will start to work on this bug.
A polite ping, still working on this bug?
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eada4adee8a32be021ee3031d07e0ccda7217e0d tdf#39593 deduplicate code using existing function It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tagezi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ddcd36d9d6191bfba7dea179067767a9ee192608%5E%21 tdf#39593 deduplicate code in TreeListBox It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dmitriy Shilin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6fa4c3e4778959d4591c053461329d396741ee64%5E%21 tdf#39593 vcl: extract SysColor list deletion It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dmitriy Shilin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/af4fab260b4e5e6cd073d449081dd057b9715881%5E%21 tdf#39593 vcl: reduce copy-paste in ImplCalcOutSideRgn It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi, I just started working on it Regards, rajprakash
Dmitriy Shilin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/53a29871800c5b520767e18c1e3f10c4d5c4852e%5E%21 tdf#39593 vcl/win/gdi: extract pen resetting into method It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dmitriy Shilin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/7311a88baa8c30eeb61d897f43ac3f5b481ed01f%5E%21 tdf#39593 vcl/win/gdi: extract brush updating into method It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I guess many people can work on this at the same time...
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b95512e936b4eebb301c169e091bd9064c1eb2ac%5E%21 tdf#39593 use existing find() to reduce copypaste It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi, Is this issue still available to take upon? Regards, raj
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/365ec7b14649b46c59e7dc3a1530b2b37bc908da%5E%21 tdf#39593 use existing clearConnectionPools() method It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/09c657ebe69fe1c2516a10a4452996870f4237d2%5E%21 tdf#39593 use UNO3_GETIMPLEMENTATION* macros It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/32eeb405d7fd6788aaa34e1bf8a04388d7a3958f%5E%21 tdf#39593 remove IMPL_XUNOTUNNEL* macros It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Re comment 52 and comment 53: For further work on this EasyHack, it is probably better if you try to come up with clean-up that doesn't involve new uses of macros. While macros may have their use in reducing boilerplate, they do have issues, so we generally try to avoid them. (Note that sometimes there may be ways to reduce boilerplate that involve templates instead of macros.)
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/cc0dc723c7d8354b5203310ef1381bbf54258eba%5E%21 tdf#39593 Remove DOM::CNode::GetImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/086c186209e33faa38403c1d9122fd2e90921b3a%5E%21 tdf#39593 Remove Graphic::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/e062d42f587ad758ecfc42967bf257a9e2e37a3d%5E%21 tdf#39593 Remove ScModelObj::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b0efb1be8ed02f34ab4a2bc0c933c4378b2715e3%5E%21 tdf#39593 Remove toolkit::GridColumn::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/60271c4433372097ef5ecc74e522532ebf5af8e0%5E%21 tdf#39593 Remove GetImplementation from ConstItemContainer and ItemContainer It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/336b9a14f65222936d000551ed9728ab13514479%5E%21 tdf#39593 Remove chart::ExplicitValueProvider::getExplicitValueProvider It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/d6a45af91bf1df9ab8aac3d8e83dba7474e15a95%5E%21 tdf#39593 Remove xforms::Submission::getSubmission It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/9e1fa327b161c24c3d588563d6a91aced50b85dd%5E%21 tdf#39593 Remove xforms::Binding::getBinding It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/9950aab9f02ab6aff71feca820575ed5a4e215d5%5E%21 tdf#39593 Remove xforms::Model::getModel It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/e2814bc4d3a3c8b63018e2733b1ac182adbd96e6%5E%21 tdf#39593 Remove static xforms::Binding::getModelImpl It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/fbead41b7d6c0346ff3373279f9c01dc4c7e61fd%5E%21 tdf#39593 Remove frm::OGridControlModel::getColumnImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/a4261757b89f6a198261006a8c9aa6b4eb8e19fb%5E%21 tdf#39593 Remove reportdesign::OSection::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6d4039c130896c57363bb60982c0b5601c4f0c3e%5E%21 tdf#39593 Remove dbaccess::OContentHelper::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/aed859c4825e10f0981686b9d8476538255b666f%5E%21 tdf#39593 Replace copy-pasted functions with template It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/3d4b1c0eee7a3055e67df6b0b342ea25b0f5bf55%5E%21 tdf#39593 Change comphelper::getImplementation signature It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/639698862d16310b60514277d59227eec37eb02a%5E%21 tdf#39593 Reduce copy-paste in XRow_impl::get* It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/499c54334a40ae969e3c7c85590a991a53b8de2e%5E%21 tdf#39593 Replace copy-pasted functions with template It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b35ae1efee703c0faa0cbf5ed4c1949456d83099%5E%21 tdf#39593 Reduce copy-paste in XRow_impl::get* some more It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f926de93c455f7cede505ad8cf849fe81eb514cf%5E%21 tdf#39593 Remove SvxUnoDrawMSFactory::concatServiceNames It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/9307a23a40a0a18d86dade102354ba4871825c5a%5E%21 tdf#39593 extract getting max row length to template function It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/3ab2df3cf755ecd0e3e31ad06872426d24222c31%5E%21 tdf#39593 Drop lcl_GetIndexFromName It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f0390929d3e71ab434f9ce8d88c2dc2f4cc0ea6e%5E%21 tdf#39593 Drop connectivity::sdbcx::ODescriptor::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/24c17dab2f10ad1b7ba342fbd40dc65b7d8f9b24%5E%21 tdf#39593 extract UnoTunnelId comparison to template function It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ed5064d819ff423766311516f2cdf0707b41cab3%5E%21 tdf#39593 Drop OToolBoxWindowItem::isWindowItem It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f599c31fe68882f510cf3d101102e71f9bf795c8%5E%21 tdf#39593 use isUnoTunnelId It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/03747db026a5b4959ec0700d9addf0482e6f5977%5E%21 tdf#39593 use isUnoTunnelId in connectivity It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c1e1806c9c01d2ac2f62f95dd79cbb2037bc87af%5E%21 tdf#39593 drop comphelper::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/694784687e502f2e68fde5c2e5d7fb860517cbf8%5E%21 tdf#39593 use isUnoTunnelId in unoxml It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/8f35bb1fcc9c1efd7edc52efbfc33509de2c00f2%5E%21 tdf#39593 Drop RootItemContainer::GetImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/5c4ba7cb99a7d4e4eefaa132e64d08fdc82ba759%5E%21 tdf#39593 use isUnoTunnelId in xmloff It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/eef2795aa105ae52607cc158504c455da87dfd2a tdf#39593 use isUnoTunnelId in dbaccess It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8e53efa926bc05d73c48579f63c3d662a96bd35e tdf#39593 use getUnoTunnelImplementation in pyuno It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b883e3d58db404a92bee044091b6cfd3892311c2 tdf#39593 use isUnoTunnelId in sd It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4342aaef0c4d6cd5c51fd2b74328bb4df5fb71dd tdf#39593 Drop ScDataPilotDescriptorBase::getImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1d398fb983d8f8b53a78e7c47b588fc1f1e7f748 tdf#39593 use getUnoTunnelImplementation It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mesut Çifci committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4054126f79c9c5b882da88444124575db3ba3a81 tdf#39593 reduce copy/paste in BitmapScaleSuperFilter It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bc817c2fb26ebbfcc7b6868fbcabb13772ddb90e tdf#39593: reduce copy/paste in Converter::convertDuration It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram wrote a helpful blog post about using Simian: http://bayramcicek.com.tr/general/2021/02/20/simian.html
Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bef0cfcf2a6d0a70adb6ddc5558d5a888edb718c tdf#39593 Ruduce copy/paste code in Converter::converterDuration It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9bee4cec215e2694f6e6e1aa4a463b47b69cc1ff tdf#39593: remove trim(), use o3tl::trim() instead It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Closing this ticket. bug 155630 has been created instead