Bug 41100 - After saving as .csv, unexpected behaviour causes silent data loss
Summary: After saving as .csv, unexpected behaviour causes silent data loss
Status: RESOLVED DUPLICATE of bug 51071
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.4.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 18:15 UTC by Tim Morley
Modified: 2013-01-19 21:21 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Morley 2011-09-21 18:15:59 UTC
When saving a spreadsheet as a .csv, the user is warned that only the current sheet is being saved. That's a useful warning.

However, if the currently open spreadsheet contains more than one sheet, the following behaviour is unexpected and destructive.

Say I have saved Sheet1 as MySheet1.csv. In my still-open spreadsheet, I go over to Sheet2, change something, and hit ctrl-S. The contents of my file MySheet1.csv are OVERWRITTEN with the data from Sheet2. I have lost the saved copy of Sheet1.

Each time I hit ctrl-S, the current sheet is saved as MySheet1.csv, but the still-open spreadsheet is marked as "Saved", and can be closed without any warning about data loss.

Speaking of data loss, it's about 30 to 40 edits over four days, in my case just now.  :o(

There are actually two problems here:
 (1) Hitting ctrl-S should not be allowed to overwrite a saved copy of one sheet with data from another sheet.
 (2) The still-open document should be marked as "modified", not "saved", unless *all* parts of it have been successfully saved since the last edit.
Comment 1 Rainer Bielefeld Retired 2011-09-22 00:33:27 UTC
I see reporter's problem, but not a big priority. Everybody knows that that will happen, and because of that I would not expect that many people continue editing a document that has been saved as .csv

I doubt that reporter's wish for a table specific "modified flag" can be fulfilled. IMHO that problem is too exotic, from  time to time the user should know what he is doing.

To handle that as .csv export instead of "save as .csv" might help, but what shall we do with .xls "export", and for .xls opened with LibO for .csv?

We also could allow "save as .csv" only for single sheet tables, but that would be a mess for users who want to do.

My conclusion:
I don't know what to do.
Comment 2 Tim Morley 2011-09-22 12:49:28 UTC
(In reply to comment #1)
> Everybody knows that that will happen, and because of that I would not
> expect that many people continue editing a document that has been saved as .csv

The fact that only one sheet gets saved is entirely expected, but the other two behaviours to me were totally counter-intuitive:
 (1) hitting ctrl-S might save something completely different from the previous ctrl-S, depending on what's on the screen at the time;
 (2) a document is happy to let itself be closed while it had unsaved modifications in it.

Both of these are highly non-standard behaviours for any desktop app, and I would dispute that "everybody knows that that will happen". I've been using 

> I doubt that reporter's wish for a table specific "modified flag" can be
> fulfilled.

That's not what I wish for. ;o) I just expect that if I've got a document open, and I try to close it while it has unsaved modifications, then I get a warning. This doesn't happen.

> To handle that as .csv export instead of "save as .csv" might help

That would solve the problem I'm describing perfectly — the .csv file would contain a single sheet, but the remaining multi-sheet document would still be saved as a .ods (or .xls or whatever).

+1 for removing "Save as .csv" and creating "Export to .csv" instead.

> but what shall we do with .xls "export", and for .xls opened with LibO for .csv?

There's no reason to "Export to .xls" instead of "Save as .xls" — why would you want to do that?

> My conclusion:
> I don't know what to do.

Yeah, you do, you just suggested it above, and I +1'ed it!
Comment 3 Björn Michaelsen 2011-12-23 12:37:37 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 4 Florian Reisinger 2012-08-14 14:03:30 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 5 Florian Reisinger 2012-08-14 14:04:25 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 6 Florian Reisinger 2012-08-14 14:08:56 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 7 Florian Reisinger 2012-08-14 14:10:57 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 8 Rainer Bielefeld Retired 2013-01-19 16:43:59 UTC
I believe this is an appropriate enhancement request, we indeed should find a way to prevent unmindful users from Dataloss.
Comment 9 Rainer Bielefeld Retired 2013-01-19 17:04:11 UTC
I think this one is a part of the more general dataloss problem in "Bug 51071 - FILESAVE: CSV should be an export, not a save-as target"

@Tim:
Please excuse us for accidently closing this report!

*** This bug has been marked as a duplicate of bug 51071 ***
Comment 10 Tim Morley 2013-01-19 21:21:45 UTC
Hi Rainer. I'm glad it's being re-opened, and thus hopefully dealt with. Thanks for the heads-up.  :)