Bug 41474 - EasyHack: obsolete rtl::O[U]StringBuffer::{charAt,setCharAt}
Summary: EasyHack: obsolete rtl::O[U]StringBuffer::{charAt,setCharAt}
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: easyHack
Depends on:
Blocks:
 
Reported: 2011-10-05 05:32 UTC by Stephan Bergmann
Modified: 2015-12-18 10:02 UTC (History)
0 users

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Bergmann 2011-10-05 05:32:51 UTC 
With <http://cgit.freedesktop.org/libreoffice/core/commit/?id=112bdf84d684590e042725c7173e059b4afa2f83> "Removed dangerous rtl::O[U]String[Buffer]::operator sal_{char,Unicode} const *." the member functions

rtl::OStringBuffer::charAt
rtl::OStringBuffer::setCharAt
rtl::OUStringBuffer::charAt
rtl::OUStringBuffer::setCharAt

(that followed a misguided inspiration from Java's StringBuffer) are obsolete.  They should be marked as SAL_DEPRECATED and their uses be replaced with uses of operator [].
Comment 1 August Sodora 2011-12-01 13:24:09 UTC 
Just finished removing these on master
Comment 2 Robinson Tryon (qubit) 2015-12-18 10:02:46 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack)
[NinjaEdit]