Bug 41544 - Compare spreadsheet with password protected file does not work
Summary: Compare spreadsheet with password protected file does not work
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.4.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 129628 129844 (view as bug list)
Depends on:
Blocks: Password-Protected Document-Comparison
  Show dependency treegraph
 
Reported: 2011-10-06 21:47 UTC by Jean-Baptiste Faure
Modified: 2020-01-17 20:57 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
test writer file 1 (152.82 KB, application/vnd.oasis.opendocument.text)
2018-11-12 21:11 UTC, Drew Jensen
Details
test writer file 2, with minor changes (152.94 KB, application/vnd.oasis.opendocument.text)
2018-11-12 21:12 UTC, Drew Jensen
Details
Test a.ods (7.42 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-12-26 15:43 UTC, Timur
Details
Test a_mod.ods pass: test (11.54 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-12-26 15:44 UTC, Timur
Details
test package (25.46 KB, application/x-bzip)
2020-01-17 20:57 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2011-10-06 21:47:15 UTC
Problem description: If you compare a spreadsheet document with another which is
password protected, you are asked for the password but your password is refused event it is the correct one.
occur

Steps to reproduce:
1. open an existing spreadsheet document, eg a.ods
2. make some minor change and save this document as a new file with password,
eg. a_mod.ods
3. close a_mod.ods and open a.ods
4. menu Edit > Compare document
5. choose a_mod.ods
6. LibreOffice ask for the password. Type in the password.

Current behavior: error message saying that the password is not correct and the file can't be opened.

Expected behavior: "Accept or Reject Changes" is shown with the minor change
done at step 2.

Analogous bug, but not exactly the same, for Writer: #41493

Defect confirmed on MS-Windows-XP and Ubuntu.

Best regards. JBF
Comment 1 Markus Mohrhard 2011-10-07 05:04:16 UTC
Might be another problem of an missing change to SID_ENCRYPTIONDATA.
Comment 2 Björn Michaelsen 2011-12-23 12:32:33 UTC Comment hidden (obsolete)
Comment 3 Jean-Baptiste Faure 2011-12-26 01:23:13 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2015-04-19 03:20:03 UTC Comment hidden (obsolete)
Comment 5 Jean-Baptiste Faure 2015-04-25 15:49:51 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2016-09-20 09:32:06 UTC Comment hidden (obsolete)
Comment 7 Jean-Baptiste Faure 2016-09-24 19:41:13 UTC
Still reproducible in LibreOffice 5.2.3.0+ and master
Version: 5.3.0.0.alpha0+
Build ID: 9aef73aa452f86df8c760ca028914fc542909a58
Threads CPU : 4; Version de l'OS :Linux 4.4; UI Render : par défaut; 
Ubuntu_16.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Calc: group

Best regards. JBF
Comment 8 QA Administrators 2018-09-14 02:46:21 UTC Comment hidden (obsolete)
Comment 9 Timur 2018-09-14 08:38:38 UTC Comment hidden (obsolete)
Comment 10 Drew Jensen 2018-11-12 21:11:05 UTC Comment hidden (obsolete)
Comment 11 Drew Jensen 2018-11-12 21:11:57 UTC Comment hidden (obsolete)
Comment 12 Drew Jensen 2018-11-12 21:12:45 UTC Comment hidden (obsolete)
Comment 13 Drew Jensen 2018-11-12 22:24:19 UTC Comment hidden (obsolete)
Comment 14 Timur 2019-12-26 13:21:17 UTC
*** Bug 129628 has been marked as a duplicate of this bug. ***
Comment 15 Timur 2019-12-26 15:43:54 UTC
Created attachment 156784 [details]
Test a.ods
Comment 16 Timur 2019-12-26 15:44:52 UTC
Created attachment 156785 [details]
Test a_mod.ods pass: test

Repro 6.5+
Comment 17 Timur 2020-01-17 17:53:52 UTC
*** Bug 129844 has been marked as a duplicate of this bug. ***
Comment 18 Julien Nabet 2020-01-17 20:57:37 UTC
Created attachment 157237 [details]
test package

I created 2 test files (password = test1 and test2)
Also, I retrieved bt from CheckPasswd_Impl, see https://opengrok.libreoffice.org/xref/core/sfx2/source/appl/appopen.cxx?r=947fdbba#168

I expected LO go twice in this method, once per file, it called this method 3 times.
The 2 first times, there was a password dialog, the third time no (it doesn't pass the line "if( xInteractionHandler.is() )", line 218 of the same file.