Bug 42155 - win32: remove duplicated / redundant stringbuffer classes
Summary: win32: remove duplicated / redundant stringbuffer classes
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:4.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2011-10-24 03:02 UTC by Michael Meeks
Modified: 2015-12-16 00:09 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2011-10-24 03:02:40 UTC
<tml_> whee, by accident /me finds yet another stringbuffer type
class, sysui/source/win32/misc/AutoBuffer.hxx etc, and duplicated in
fpicker/source/win32/misc

This class should be removed and we should use sal/inc/rtl/ustrbuf.hxx's OUStringBuffer instead. Shouldn't be extremely difficult, but needs to be done / build-tested using mingw32 / or under windows itself [ compiling under windows is not for the faint hearted ].
Comment 1 Florian Reisinger 2012-05-18 09:12:08 UTC
Deteted "Easyhack" from summary
Comment 2 Thomas Arnhold 2013-03-18 15:34:39 UTC
This class (CAutoUnicodeBuffer) is now at fpicker/source/win32/misc/AutoBuffer.hxx.
Comment 3 Commit Notification 2013-09-05 16:30:40 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=36baf31d2baa30c34c05b042283845ed348be888

fdo#42155: Replace the only use of CAutoUnicodeBuffer part1



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2013-09-08 03:32:31 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a92be728a5affb7d74eeeec8c6831968c05aeff4

fdo#42155: Replace the only use of CAutoUnicodeBuffer end part



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Robinson Tryon (qubit) 2015-12-16 00:09:05 UTC
Migrating Whiteboard tags to Keywords: (EasyHack, DifficultyBeginner, SkillCpp, TopicCleanup )
[NinjaEdit]