Bug 42783 - get rid of CPU define/build system variable
Summary: get rid of CPU define/build system variable
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: Other All
: medium normal
Assignee: Not Assigned
Whiteboard: target:3.6.0
Keywords: difficultyBeginner, easyHack, skillScript, topicCleanup
Depends on:
Reported: 2011-11-10 04:11 UTC by Björn Michaelsen
Modified: 2015-12-16 00:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

First try at EasyHack (35.66 KB, patch)
2012-02-25 03:16 UTC, Thomas Collerton

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2011-11-10 04:11:21 UTC
The variables CPU and CPUNAME contain exact the same information and the existence of both leads can just lead to needless errors. CPU is limited to one character leading to obnoxious names like "R" for arm or "6" for Motorola 68000, thus is it the obvious candidate to go an be replaced by CPUNAME.
Comment 1 Björn Michaelsen 2011-11-10 04:12:04 UTC
Skills: code reading, some building
Comment 2 Thomas Collerton 2012-02-25 03:15:58 UTC
This is my first try, though i had to skip the SPARC64 bits, being CPU=U not defined in configure.in
Comment 3 Thomas Collerton 2012-02-25 03:16:37 UTC
Created attachment 57629 [details]
First try at EasyHack
Comment 4 Michael Meeks 2012-05-09 02:27:51 UTC
Norbert commented on the list:

> The patch does not remove CPU, just replace some of it's use with CPUNAME.
> among other annoying part is the fact that prebuilt moziila filename
> are based on CPU not CPUNAME
> so any such patch need to be synch with a rename of these files... and
> somehow a rename of the existing file in moz/zipped if there are
> there...

prolly best to continue discussion there; thanks !
Comment 5 Not Assigned 2012-05-09 07:35:36 UTC
Thomas Collerton committed a patch related to this issue.
It has been pushed to "master":


EasyHack fdo#42783: get rid of CPU define/build system variable
Comment 6 Robinson Tryon (qubit) 2015-12-16 00:19:56 UTC
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillScript TopicCleanup )