Bug 42790 - get rid of PRODUCT define/build system variable
Summary: get rid of PRODUCT define/build system variable
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillScript
Depends on:
Blocks:
 
Reported: 2011-11-10 08:36 UTC by Björn Michaelsen
Modified: 2015-12-15 16:24 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Patch for issue 42790 (2.94 KB, patch)
2012-02-17 11:36 UTC, Laurent Balland 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2011-11-10 08:36:11 UTC 
The variables PRODUCT and DBG_UTL in the build system are containing the same information:
- a --enable-dbgutil build has PRODUCT unset and DBG_UTL set
- a --disable-dbgutil build has DBG_UTL unset and PRODUCT set
so one of them has to go.

As a quick grep by mmeeks revealed PRODUCT to be used rarer, it should be not be used anymore and existing occurrences should be replaced with a test for DBG_UTL.
Comment 1 Laurent Balland 2012-02-17 11:36:52 UTC 
Created attachment 57227 [details]
Patch for issue 42790
Comment 2 Björn Michaelsen 2012-02-20 09:33:25 UTC 
patch pushed to master as:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=26bd18dfc2516aab507dfb478cfc31e4bf57442f


still a few more occurrences in solenv.
Comment 3 Björn Michaelsen 2012-02-20 09:37:11 UTC 
@Laurent: Could you add yourself to http://wiki.documentfoundation.org/Development/Developers
Comment 4 Björn Michaelsen 2012-02-21 08:49:39 UTC 
on a second thought, the ones in solenv are only related to the old build system. 
resolving as worksforme.

Laurant, Thank you for this patch!
Comment 5 Laurent Balland 2012-02-21 09:47:09 UTC 
(In reply to comment #3)
> @Laurent: Could you add yourself to
> http://wiki.documentfoundation.org/Development/Developers

Done.

> Laurant, Thank you for this patch!
You're welcome!

Laurent BP
Comment 6 Robinson Tryon (qubit) 2015-12-15 16:24:54 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillScript )
[NinjaEdit]