Bug 43209 - Implement line cap butt, round and square as defined in ODF 1.2
Summary: Implement line cap butt, round and square as defined in ODF 1.2
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: x86 (IA32) Windows (All)
: medium enhancement
Assignee: Michael Meeks
URL:
Whiteboard: odf
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 14:17 UTC by Regina Henschel
Modified: 2013-02-27 13:46 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
This contains the changes up to now. It is far away from being finished. (43.76 KB, patch)
2011-12-09 06:32 UTC, Regina Henschel
Details
Still nothing to commit but only to inform interested developers (53.49 KB, patch)
2011-12-26 06:57 UTC, Regina Henschel
Details
Next intermediate state (64.22 KB, patch)
2012-01-01 15:12 UTC, Regina Henschel
Details
technical correct patch, license review needed (172.37 KB, patch)
2012-05-16 04:32 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2011-11-23 14:17:55 UTC
ODF 1.2 defines for line the line cap styles butt, round and square. LibreOffice is missing this feature. It should be implemented. I will work on it.
Comment 1 Regina Henschel 2011-12-09 06:32:33 UTC
Created attachment 54268 [details]
This contains the changes up to now. It is far away from being finished.

The file contains the changes I have made up to now. It is far away from being finished. The purpose of the file is to allow other developers to watch the work and to intervene if they think I should to it in a different way.
[I know that the files LinCap.idl and xlncapit.hxx have a wrong license statement, that will be corrected in the end.]
Comment 2 Regina Henschel 2011-12-26 06:57:50 UTC
Created attachment 54826 [details]
Still nothing to commit but only to inform interested developers

This is still not ready to commit, but only to inform interested developers. You can already see the line caps in editing mode, but they are not printed yet.

Eventually added arrow heads are added in addition to the line caps. That is the same way browsers render such lines in svg.
The caps are added to dashes, same as it is done in svg.
Comment 3 Regina Henschel 2012-01-01 15:12:40 UTC
Created attachment 55030 [details]
Next intermediate state
Comment 4 Michael Meeks 2012-05-08 13:48:30 UTC
I believe the best approach here is to merge the work you did with Armin; is that right Regina ? :-) [ I'm still working on that ... here ]
Comment 5 Regina Henschel 2012-05-08 14:38:23 UTC
Are you ready to take code with Apache License, Version 2.0?

I have taken a diff from AOO, but have not tried to merge it into LO yet. Should I do it despite of license questions, so that all other merge conflicts are solved so far? Or what way is advisable?
Comment 6 Regina Henschel 2012-05-16 04:32:54 UTC
Created attachment 61712 [details]
technical correct patch, license review needed

The attached patch has a wrong bug number in the comment, please correct it to fdo#43209

The patch brings the line cap feature from AOO3.4 to LO3.6. It is technical correct (hopefully). The whole patch is under Apache License 2.0. The patch is not completely done by me, but second author is Armin Le Grand, Armin.Le.Grand@me.com.

Compared to AOO3.4 I had to make some minor technical changes to get it apply-able to LO3.6, e.g. sal_Bool -> bool.

The patch does not contain lincens marks on the changes, because I do not know, if those are needed and if it is needed, in which form this has to be done.

The two new files svx/inc/svx/xlncapit.hxx and offapi/com/sun/star/drawing/LineCap.idl have got Apache License 2.0 headers. I don't know whether this has to be changed to another header.
Comment 7 Michael Meeks 2012-05-16 05:47:05 UTC
Accepting AL2.0 code at this time is not possible without new license headers, and clarity from existing committers on their licensing - unwinding that fully and carefully is a work in progress.

Sorry for the delay.
Comment 8 Thorsten Behrens (allotropia) 2012-07-26 12:53:10 UTC
Adding Michael to the loop.
Comment 9 Michael Meeks 2012-07-26 14:52:49 UTC
So - I'll take this; I'm working towards it steadily with the re-basing work :-)
Comment 10 Samuel Mehrbrodt (allotropia) 2013-02-07 20:54:31 UTC
I guess this is done, can I close this issue?
Comment 11 Michael Meeks 2013-02-27 13:46:07 UTC
Yes - thanks to Regina - this is indeed done for 4.0 :-)