Bug 44527 - Media Player / Media toolbar controls don't switch theme properly
Summary: Media Player / Media toolbar controls don't switch theme properly
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Media-Player-Dialog Icon-Themes-Code-UpdateUI
  Show dependency treegraph
 
Reported: 2012-01-06 05:05 UTC by Stefan Knorr (astron)
Modified: 2023-05-13 21:31 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Knorr (astron) 2012-01-06 05:05:29 UTC
The large versions (and they exist) of the media control icons are never used, even if the icon size "large" is enabled. Additionally, switching the theme has no effect until one closes and then opens the Media Player window/Media toolbar again.

How to reproduce:

0. Open Writer/Impress/Draw
1. Open the Gallery (Tools > Gallery)
2. Choose on "Sounds"
3. Double-click a sound (Media Player window appears)
4. Switch to a large theme: Tools > Options, choose View, Select "Large" and a different icon theme (ideally, only switch between Galaxy/High Contrast, and in Master builds after January 7, 2011, Tango, as only these themes provide different icons here)
5. Observe that the Media Player's theme has not changed
6. Close Media Player window, Click on "Sounds" again, and choose another sound to preview it.
7. Observe that Media Player's theme has changed, but is still using small (16*16) icons

Expected: Media player switches to selected theme with large icons immediately, like the rest of the UI.
Comment 1 sasha.libreoffice 2012-03-14 08:40:36 UTC
Reproduced in 3.3.4 and 3.5.1 on Fedora 64 bit and Windows Xp 32 bit
Changing version to 3.3.4 as most early reproducible
Comment 2 Andras Timar 2013-04-15 07:38:31 UTC
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=2a6009ffc10dc64dd6f8dc23f653ee8a49f9d86d

This commit solves part of the issue. Large icons are used when icon size is set to large. However theme and size do not change immediately. (target: 4.1)

BTW Formula Bar in Calc does not change theme, too. It changes the size though.
Comment 3 A (Andy) 2014-09-27 18:46:56 UTC
Step 5: if the media player is not closed before changing VIEW the buttons stay small, but after you close it and select again a sound the buttons will be large

therefore: Step 7: for me not reproducible with LO 4.3.2.2 (Win 8.1)

All in all with LO 4.3.2.2 (Win 8.1) now only partly reproducible.
Comment 4 QA Administrators 2015-10-14 19:56:55 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2016-11-08 11:13:44 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2019-12-03 13:59:53 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2021-12-03 04:24:26 UTC Comment hidden (obsolete)
Comment 8 Stéphane Guillou (stragu) 2023-05-13 21:31:38 UTC
Still reproduced in recent master build:

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: b5a22fceed57f05eb43a5fb0817afbc141610c5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Change in icon theme needs a dialog close and reopen to update.

Same in OOo 3.3, marking as inherited.