Quoted class wraps std::list - why not port the code over to use std::list directly, that avoids cluttering semantics on a per-module basis.
Created attachment 57921 [details] Removed every use of LinkedList and replaced it with std::list Hi! I removed every use of LinkedList and replaced it with std::list I hope everything's correct. Tested it with the .hwp file in hwpfilter/qa/cppunit/data (pass and fail). Working as expected. LinkedList had a find(int n) method, which returned the underlying std::vector's nth element, unfortunately this isn't possible with std::list, so the calls to find(...) and replaced with iterating with a for loop i times, thus pointing the iterator to the nth element of the list. Don't know if it's a very good solution though. The original find method had an assertion that the parameter is between 0 and the size of the underlying vector. If something is wrong, let me know, and i try to enhance/work on it. Or feel free to improve it :) Szabolcs
(In reply to comment #1) > Created attachment 57921 [details] [review] > Removed every use of LinkedList and replaced it with std::list > LinkedList had a find(int n) method, which returned the underlying > std::vector's nth element, unfortunately this isn't possible with std::list, so > the calls to find(...) and replaced with iterating with a for loop i times, > thus pointing the iterator to the nth element of the list. I mean n times :) Iterating n times...
I see Tor's committed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=db74590950afc8def36a42abae786be5ebad85d9 Could we mark this as fixed?
Indeed, thanks for the patch -> fixed.
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyEasy,SkillCpp) [NinjaEdit]
difficultyEasy -> difficultyBeginner. The former never really existed and only makes the EasyHack not appear on the wiki.
*** Bug 146351 has been marked as a duplicate of this bug. ***