Bug 46361 - FILEOPEN: Faulty import of docx file which contains a simple drawing
Summary: FILEOPEN: Faulty import of docx file which contains a simple drawing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: Other All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: BSA target:3.6.0 target:4.2.0 target:...
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-02-20 11:35 UTC by Stefan Schweizer
Modified: 2013-07-02 14:19 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
MS Word 2007 document with a simple drawing (18.50 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2012-02-20 11:35 UTC, Stefan Schweizer
Details
PDF of the MS Word document with a simple drawing (8.04 KB, application/pdf)
2012-02-20 11:37 UTC, Stefan Schweizer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schweizer 2012-02-20 11:35:56 UTC
Created attachment 57348 [details]
MS Word 2007 document with a simple drawing

Problem description: 
LibreWriter does not import a MS Word 2007 document with a simple drawing correctly.

Steps to reproduce:
1. Open attached docx file

Current behavior:
LibreWriter imports the docx file but shows only text without colored boxes

Expected behavior:
LibreWriters shows correct drawings (see PDF attachment)

Platform (if different from the browser): 
              
Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Comment 1 Stefan Schweizer 2012-02-20 11:37:05 UTC
Created attachment 57349 [details]
PDF of the MS Word document with a simple drawing
Comment 2 s-joyemusequna 2012-02-21 03:47:15 UTC
LO 3.3.4 displays the boxes (but no background colour), the text is missing

LO 3.4.5 displays an empty page (two empty paragraphs)

LO 3.5.0 displays only the text (text size and colour are OK)


So this is a partial regression.
Comment 3 Miklos Vajna 2012-06-01 08:05:01 UTC
This is a VML import issue, looks like a v:rect is not imported if it's inside a v:group.
Comment 4 Not Assigned 2012-06-01 08:57:44 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=229f6e187bd85d0af47da9feffef2d9ac7f83120

Related: fdo#46361 fix VML import of v:rect's fillcolor
Comment 5 Miklos Vajna 2012-06-01 08:59:09 UTC
OK, there are multiple issues here.

First, if the v:group containing the v:rect is removed, then the v:rect is imported, but the background color was missing, I just fixed that.
Comment 6 Miklos Vajna 2013-07-01 15:59:08 UTC
This got a bit improved with d5c934d150cb6cea5f96cbbee4fb5e8312bf027e, the remaining issues I see:

- green text is black
- missing newlines where there are multiple w:p
- missing newline when there is a w:br
- vertical alignment should be top, but it's center
- the paragraphs should be centered, but they are left

I'll push fixes for these in a bit.
Comment 7 Commit Notification 2013-07-02 10:00:05 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b1f78c44c1acc246f06a963383232c9bf649a06b

fdo#46361 oox: handle w:br for groupshape textboxes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2013-07-02 10:00:29 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f24e4c74d7d6a7d95090c6fa6a584fed7787706c

fdo#46361 oox: handle multiple w:p for groupshape textboxes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2013-07-02 10:00:48 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6bf79576aeca243db553ed3b5eade492dc35337b

fdo#46361 oox: VML import of v-text-anchor for drawinglayer shapes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2013-07-02 10:01:07 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a737fca37cd5a5f90aa03a30688d447677d3b8a

fdo#46361 oox: handle w:jc for groupshape textboxes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2013-07-02 10:01:26 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef53d4aec2a3d690de2c7cdaf73ca95bbe29a433

fdo#46361 oox: handle w:color for groupshape textboxes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2013-07-02 10:01:45 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a2105b002c482e6536d5c3046c9e7783c0cdca3

fdo#46361 testcase



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 13 Miklos Vajna 2013-07-02 11:03:15 UTC
Fixed on master, -4-1 review: https://gerrit.libreoffice.org/4675
Comment 14 Commit Notification 2013-07-02 14:19:41 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b4d78598c55389b24b4a5016279aed26ac0fb2e&h=libreoffice-4-1

fdo#46361 oox: fixes for the VML import of groupshape textboxes


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.