Bug 46583 - borders tabpage UI doesn't display border properties nicely when lines are different
Summary: borders tabpage UI doesn't display border properties nicely when lines are di...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
: 39336 (view as bug list)
Depends on:
Blocks: Writer-Styles-Paragraph Borders-Tab
  Show dependency treegraph
 
Reported: 2012-02-24 09:58 UTC by Jon Grossart
Modified: 2017-06-07 03:34 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Grossart 2012-02-24 09:58:27 UTC
Problem description: If you add a custom border to a style, it works correctly and you have have different sizes to each (i.e., top and bottom). However, if you go back in to re-edit them, the UI shows both as being the default of 0.05 pt even if you changed them. If you keep top and bottom at the same value, the UI reloads the modified value correctly. This may be a bigger problem with other settings as well, but I only noticed it with borders.

Steps to reproduce:
1. set an H1 style in Writer
2. modify the style to have a border top and bottom
3. change the thickness of them
4. save changes ("OK")
5. re-edit style
6. make the top and bottom border different
7. save changes ("OK")
8. re-edit style

Current behavior:
4. style updates "correctly" (oh my...so many bugs in styles ATM).
5. borders width show up correctly allowing re-editing
7. different thickness borders show up "correctly"
8. border widths reset to 0.05pt instead of pulling up the custom values you set it to. There is no way to get those values back correctly via UI.

Expected behavior:
8. the customs widths you put in would be shown again for each item you set it with.

Platform (if different from the browser): 
              
Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Comment 1 Michael Stahl (CIB) 2012-05-23 04:05:38 UTC

svtools/source/control/ctrlbox.cxx
cui/source/tabpages/border.cxx
Comment 2 Michael Stahl (CIB) 2012-05-23 04:16:36 UTC
oops, pushed wrong key, let me complete that...

this problem has nothing to do with styles but is a general
problem of the borders tabpage, which already existed in OOo:
if the border lines are different, then it will not display
the properties nicely; this is difficult to do anyway with
a single width/style/color control.

what could be done easily though is to update the width/style/color
control when the user selects an individual line, to display
the properties of that line.

the tab page already has 4 different padding(line spacing)
controls, it would be possible to do the same for
the lines but it needs up to 6 controls (when the dialog
is for a Table there are inner and outer lines),
and it is going to become very cluttered.

some input from UX would be nice, what is the best way
to go here?

AFAIR the dialog is implemented in these files:

svtools/source/control/ctrlbox.cxx
cui/source/tabpages/border.cxx
Comment 3 Jon Grossart 2012-05-23 16:10:05 UTC
While I can agree that it needs some work, I still think it is a bug rather than an enhancement. If I apply a special style that hits this issue, there is no way to edit it without recreating it. I can't imaging that was ever the "correct behavior" as intended.
Comment 4 Michael Stahl (CIB) 2012-08-20 20:31:49 UTC
*** Bug 39336 has been marked as a duplicate of this bug. ***
Comment 5 Björn Michaelsen 2013-10-04 18:46:43 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 6 Cédric Bosdonnat 2014-01-20 09:00:27 UTC
Restricted my LibreOffice hacking area
Comment 7 Robinson Tryon (qubit) 2015-12-14 06:22:32 UTC Comment hidden (obsolete)
Comment 8 Jon Grossart 2015-12-20 22:58:06 UTC
Tested in LibO 3.3.0, so setting to inherited.

Also, a better description of the behaviour I would expect:

On click of a button styling (all 4 edges, sides, etc.), it would set those boarders on at the current settings for parameters.

On first click of an edge on the preview, it would load the current settings into the parameters. Once loaded, subsequent click on that edge would toggle the state.

Clicking on a different edge would restart the process.
Comment 9 Robinson Tryon (qubit) 2016-02-18 14:52:15 UTC Comment hidden (obsolete)