Julien found this deadlock: > On master only (I don't have the problem on 3.5 branch), Base hangs when I > try to close it. I must select "Tables"/"Queries" or others to have the > problem. If I just open a file and close, i don't have this problem. i can reproduce this on current master from yesterday, master 8829b7c9, master 46506f82, but not master 904d59fa or libreoffice-3-5. so it looks like a recent regression. the proposed patch by mmeeks probably does not fix the problem, because the SolarMutex is locked some more up the stack of the main thread: > void SAL_CALL OGenericUnoController::dispose() throw(::com::sun::star::uno::RuntimeException) > { > SolarMutexGuard aSolarGuard; > OGenericUnoController_Base::dispose(); > } http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/25838 i'd guess the deadlock was caused by this commit, which introduced the + m_pEventBroadcaster->join(); 81921bec4b81b7e3e87c24a6b4e3cfdd0cced47d
Created attachment 58176 [details] patch Nice hunting Michael - what did you think of my patch ? :-) [ which I re-attach ]
@mmeeks: if you had actually read the description you would have noticed that i don't think the patch will work :)
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=490f83d4807a4223bae61d34913e5bd2bf952f3a fdo#47021: the naive join attempt leads to deadlock
...turns out the attempt of <http://cgit.freedesktop.org/libreoffice/core/commit/?id=81921bec4b81b7e3e87c24a6b4e3cfdd0cced47d> "Make sure spawned thread is joined again" was too naive. So better avoid the deadlock and instead live with the occasional test failure for now (the problem leading to the naive join attempt had been some test failing during shutdown).
I added Fix submitter as assignee because this will ease queries and bug tracking.