Bug 47667 - Create chart test documents
Summary: Create chart test documents
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillTest, topicQA
Depends on:
Blocks: Chart 48923
  Show dependency treegraph
 
Reported: 2012-03-21 10:26 UTC by Markus Mohrhard
Modified: 2017-05-10 13:00 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
GráficosBarrasApiladasHorizontales_ChartBarStackedHorizontal (20.99 KB, application/vnd.oasis.opendocument.spreadsheet)
2012-03-24 18:47 UTC, m.a.riosv
Details
Performance Smooth 3D lines Sample Chart Document (15.27 KB, application/vnd.oasis.opendocument.spreadsheet)
2012-03-28 22:36 UTC, Rainer Bielefeld Retired
Details
Horizontals Bars with different trendlines (27.21 KB, application/vnd.oasis.opendocument.spreadsheet)
2012-04-08 08:41 UTC, Rafael Dominguez
Details
#39827 slightly edited test document for bug #39827 (34.00 KB, application/vnd.oasis.opendocument.spreadsheet)
2012-04-17 23:15 UTC, Florian Reisinger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Mohrhard 2012-03-21 10:26:17 UTC
Development around chart issues is right now a bit limited because we are missing a good set of test documents to prevent regressions. We should create a set of test documents that can be used to test as much chart features as possible to prevent adding regressions when fixing bugs.

These test documents will be also used in a automatic test concept that checks that charts are imported correctly.

This task does not require any development knowledge just a bit of time and a bit motivation to play with different chart features in calc.
Comment 1 Markus Mohrhard 2012-03-23 15:04:01 UTC
Just some more details:

It would be great to see test documents that focus on one feature and show different aspects of one feature. E.g. documents showing different parts of complex categories would be highly appreciated.

Some features are but not limited to them:
-trendlines
-complex categories
-number formats in charts
-different cahrttypes
-error bars
-...

The files will be collected here and for easy access moved to the other Libreoffice test files at:

http://cgit.freedesktop.org/libreoffice/contrib/test-files/tree/
Comment 2 m.a.riosv 2012-03-24 18:47:30 UTC
Created attachment 58991 [details]
GráficosBarrasApiladasHorizontales_ChartBarStackedHorizontal
Comment 3 m.a.riosv 2012-03-24 18:48:44 UTC
A graph with horizontal stacked bars, with transparent background to use formatted cells as background with the twelve months, to visualize the fruit production distributed along the year. I was make to answer a request in the Spanish OOo forum.
Comment 4 Rainer Bielefeld Retired 2012-03-28 22:36:46 UTC
Created attachment 59186 [details]
Performance Smooth 3D lines Sample Chart Document

The disadvantage of that first example is that it's not easy to find out for what tests it should be used. 

I believe test documents should fulfill following criteria

Document Name should give a hint concerning test
Spreadsheet document should contain information in a sheet named "TestInstructions":

Author of document:
Tests for:
Expected test result:
How to reproduce (facultative):
Unexpected (facultative):

I attach "Performance3DSmoothLines.ods" following these ideas

Here is a query leading to Bugs with charts:
<https://bugs.freedesktop.org/buglist.cgi?list_id=59306&field0-0-0=attachments.filename&query_format=advanced&type0-0-0=casesubstring&value0-0-0=.ods&component=Chart&product=LibreOffice>

For collecting test charts I propose following proceeding:

1. Run this modified shared query: 
<https://bugs.freedesktop.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=ChartSampleRework&sharer_id=19321&list_id=59322>
2. Attach reworked sample document here with some hints
3. "Edit Search" from step 1
4. Add Bug ID number of bug where you found the document to 
   Second line "Bug ID" of "Custom Search"
5. Search
6. Remember Search

I hope that proceeding will work, I do not have much experience with those shared queries.

@Markus: May be you want to give some additional hints concerning requirements for optimum test documents?
Comment 5 Only A Test Account, do not aadd to CC! 2012-03-28 23:44:36 UTC
My concern was qualified, the common editing of a named shared query will not work. So please add Reviewed bugs here in the whiteboard behind "AlreadyReviewedBugs:", I will keep the query up to date.
Comment 6 Markus Mohrhard 2012-03-29 11:35:03 UTC
> @Markus: May be you want to give some additional hints concerning requirements
> for optimum test documents?

Hey,

so ideally we want a set of newly written test documents that each contain a set of charts focus on one feature. Ideally these documents should be licensed MPL/LGPLv3+ because we are using the test documents in our in-build tests and they will become part of the source code but will not end up in the release.

I'm happy with maybe 2 to 5 real world documents that stress several different ffeatures at once but not more because they make it quite hard to find and debug regressions.

So I think we should not try to use existing bug documents because they often are not focused on one single feature.

I still hope that we get some users contributing test docs.
Comment 7 Rafael Dominguez 2012-04-08 08:41:12 UTC
Created attachment 59647 [details]
Horizontals Bars with different trendlines

Is this simple enough?? Just drawing a chart and use different trendlines on it.
Or should i just use more data??
Comment 8 Markus Mohrhard 2012-04-08 09:35:36 UTC
(In reply to comment #7)
> Created attachment 59647 [details]
> Horizontals Bars with different trendlines
> 
> Is this simple enough?? Just drawing a chart and use different trendlines on
> it.
> Or should i just use more data??

It is a good test document.

Since you are a dev you can even think about extending the chart2 layout dumper in chart2/source/view/charttypes/ChartView.cxx. Right now the dumper only covers some basic information but we should extend the dumped information and finally I need to spend some time enabling the regression test.
Comment 9 Rainer Bielefeld Retired 2012-04-17 04:38:07 UTC
@Florian:
When you create test documents, please use a structure similar to "Performance Smooth 3D lines Sample Chart Document", but with test instructions contents in the same sheet as the textcase itself. So all contribution of an author for a particular test is all together in 1 sheet, and if an other author has an idea for a related test, he can simply add a sheet, upload the new and obsolete the old version of the document.

I believe sample charts for axis label (number) format would be useful (beneath lots of other test cases).
Comment 10 Florian Reisinger 2012-04-17 23:15:32 UTC
Created attachment 60231 [details]
#39827 slightly edited test document for bug #39827

#39827: Is this kay too..?
Comment 11 Florian Reisinger 2012-04-17 23:38:24 UTC
Another document, which I created for a bug: https://bugs.freedesktop.org/show_bug.cgi?id=48858
Comment 12 Markus Mohrhard 2012-04-18 16:11:06 UTC
@Florian: can you just quickly write a mail to the qa or dev list confirming that your contributions including test files is under LGPLv3+/MPL?
Comment 13 Markus Mohrhard 2012-04-18 16:15:47 UTC
@Rainer, Florian: We can't just use bug files because they are not covered by LGPLv3+/MPL. Either we need to ask the author of the files if they would provide the document under the correct licenses or we create our own test documents. Personally I prefer number two for the in-build test but collecting here a set of nice test document for manual testing might be also a good idea.
Comment 14 Björn Michaelsen 2013-10-04 18:47:57 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 15 Kevin Suo 2013-11-01 09:47:11 UTC
The attachment as shown in Bug 71075 should be the simplest chart test template. (Chart copy between applications).
Comment 16 Björn Michaelsen 2015-02-10 09:09:46 UTC
Unassigning, this bug doesnt block: multiple people can work on in in parallel without interference.
Comment 17 Robinson Tryon (qubit) 2015-12-10 11:29:47 UTC Comment hidden (obsolete)
Comment 18 Robinson Tryon (qubit) 2016-02-18 14:52:35 UTC Comment hidden (obsolete)
Comment 19 jani 2016-04-26 08:51:41 UTC
Not my scope