If you do: $ git grep -3 'i97876' You can see all the instances where someone [!] has cut/pasted a bunch of near-identical code to emit UNO callbacks on the model. This needs to be turned into a (perhaps several) pleasant helper functions on the model and all mention of that issue expunged. Bonus points are awarded ;-) for a clean solution that doesn't involve client code having to emit the model's signals itself - while keeping the reasonably efficient single emission for multiple ranges functionality :-) Thanks !
This is a Calc issue, therefore changed the 'Component' field accordingly.
Deleted "Easyhack" from summary.
I'd like to work on it to get 'a first taste' of how LO is written. Is there any special procedure to do ?
I suggest we add a method to sc/source/ui/inc/docsh.hxx and sc/source/ui/docshell/docsh.cxx to emit this signal - that includes the code that is cut/pasted everywhere. Then cleanup all these instances, and any others that are not annotated with that bug to use your new method :-) Shouldn't be so hard I hope.
I've submitted a patch for this on: https://gerrit.libreoffice.org/#/c/337/. I hope it's all right.
I gave my approval for your commit on gerrit. I'm not too used to using gerrit, so I'm not sure if I did it right, or I need to do anything more to push your commit to master...
Thanks ! I guess someone still needs to verify/push the code but I have no clue who may do this...
Sorry. there is a merge conflict. Any chance you can revise your patch?
I'm sorry but I won't go further on this patch. This is just a minor rewrite attempt and is not worth the effort. Moreover, Eike Rathke pointed out in its review that this patch introduces a potential performance regression only to make tha code cleaner. I think it is more valuable to focus on something else.
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1077b3cbdb847a452fccd15d9b834bc262cfb62 fdo#47958: gross cut/paste signal emission nonsense The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cb01c477cf1e84f6e1b2ca1771a9af53d81dc59 Resolves: fdo#47958 shrink cut/paste more and rework a bit The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyInteresting SkillCpp TopicCleanup ) [NinjaEdit]
Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit]