Problem description: ==================== The MSI package is not built like expected. All file versions are different from the real existing. Unversioned files must get an special entry in the msifilehash table! Steps to reproduce: =================== 1. open msi package and look inside with Orca, InstEd or InstallShield Current behavior: ================= In cause of deployment in networks, automatic reparature failed in cause of missing sources. Expected behavior: ================== The MSI installer gets correct informations about all files and file versions or msi file hashes from the original vendor msi package, like demonstrated in the problem description above. Platform (if different from the browser): Browser: Mozilla/5.0 (Windows NT 6.1; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Currently all files have the version 9.400.102.0 which is clearly wrong and I wanted to fix that. Populating MsiFileHash table is a bigger task, we have 22220 files currently, many of them unversioned (only dll and exe files have version).
It´s no big deal. we fixed it in minutes at your msi. we can now deploy a bug free transformed msi. if you need help, you´re invited to mail us. it´s our daily business. Best regards Hardy Jacobs -- Sotec GmbH network solution & media design Streustr. 68 13086 Berlin FON: 0700 - 76832366 FAX: 0700 - 76832329 www.sotec-berlin.de Registergericht: Amtsgericht Berlin, HRB 84087 Geschäftsführer: Oliver Mück, Hardy Jacobs -- -----Ursprüngliche Nachricht----- Von: bugzilla-daemon@freedesktop.org [mailto:bugzilla-daemon@freedesktop.org] Gesendet: Freitag, 30. März 2012 17:20 An: info@sotecnet.com Betreff: [Bug 48087] : file versions in msi file table are incorrect https://bugs.freedesktop.org/show_bug.cgi?id=48087 Andras Timar <timar74@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Andras Timar <timar74@gmail.com> 2012-03-30 08:20:21 PDT --- Currently all files have the version 9.400.102.0 which is clearly wrong and I wanted to fix that. Populating MsiFileHash table is a bigger task, we have 22220 files currently, many of them unversioned (only dll and exe files have version). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You reported the bug.
Because of this, all files with a version in 3.5.1 and 3.5.2 shows 3.5.0.202. Secunia (http://secunia.com/) had also a problem with this bug, because they had looked on the version and ment, I haden't installed the new version.
Hi, Are you going to release that fixed MSI. GPO deployment is impossible now. If not could you show us, or at least point us how could you've fixed the buggy MSI? Thanks. (In reply to comment #2) > It´s no big deal. we fixed it in minutes at your msi. we can now deploy a bug > free transformed msi. > if you need help, you´re invited to mail us. it´s our daily business. > > Best regards > > Hardy Jacobs > > > -- > Sotec GmbH > network solution & media design > Streustr. 68 > 13086 Berlin > > FON: 0700 - 76832366 > FAX: 0700 - 76832329 > www.sotec-berlin.de > > Registergericht: Amtsgericht Berlin, HRB 84087 > Geschäftsführer: Oliver Mück, Hardy Jacobs > -- > > > > -----Ursprüngliche Nachricht----- > Von: bugzilla-daemon@freedesktop.org [mailto:bugzilla-daemon@freedesktop.org] > Gesendet: Freitag, 30. März 2012 17:20 > An: info@sotecnet.com > Betreff: [Bug 48087] : file versions in msi file table are incorrect > > https://bugs.freedesktop.org/show_bug.cgi?id=48087 > > Andras Timar <timar74@gmail.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|UNCONFIRMED |NEW > Ever Confirmed|0 |1 > > --- Comment #1 from Andras Timar <timar74@gmail.com> 2012-03-30 08:20:21 PDT > --- Currently all files have the version 9.400.102.0 which is clearly wrong and > I wanted to fix that. > > Populating MsiFileHash table is a bigger task, we have 22220 files currently, > many of them unversioned (only dll and exe files have version). > > -- > Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- You reported the bug.
Created attachment 60659 [details] instructions You can use our instructions to solve this bug
GPO deployment is another bug. This fixes only the specified bug (file versions and language)
(In reply to comment #5) > Created attachment 60659 [details] > instructions > > You can use our instructions to solve this bug I started to work on this bug today. Many thanks for the instructions, they are really helpful, and good to know that it takes only a few lines of VBScript to get this straight. I've already implemented correct file versioning into our installer maker Perl script. I want to build the MsiFileHash table, too. I'll see, if I can use WiFilVer.vbs, or implement the same functionality in Perl.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5525fb3ab80d0899de8eabe11498e3ee75ca0ceb fdo#48087 get real version numbers from executables for the File table of MSI
Ah, good if this mess finally is getting some handling; this has caused quite some suffering and confusion back in go-oo days, when we last tried to use MSI patching. We also attempted to use the MsiFileHash table then. Unfortunately (I mean luckily) I have forgotten all the details. I was left with the impression that in MSI technology, nothing is as obvious as it first seems, often it was like "ha, let's do this, why hasn't anybody [in OOo] thought of this before", and then after some month it turned out to be a bad idea anyway. I *think* I remember that especially peeking in the resource block versions in the executable files (which we did do at one stage) turned out not to be a good idea anyway. But of course, it might be that some premise has changed, and now things are different. Some potentially useful information might be found in old git commit logs for various patches in the "build" repository, or in old email from me in the mailing list we used at that time. Whether that is archived anywhere I have no idea. Or then such information will just be misleading now and perhaps lead onto using wrong approaches.
(In reply to comment #6) Thank you for the fix. Is there any other GPO deployment bug opened or should I open it? I can't find any thing related, but don't want to duplicate an (important IMHO) issue :-) Cheers
(In reply to comment #10) Bug #45750 was one (and there were a few duplicates). Do you have something else to report? Then please file a new bug.
(In reply to comment #11) Exactly the same as Bug #45750. I can't see why it's not an MSI bug since LaunchCondition is already set to Privileged. I'll stick to 3.4.8 till 3.5.4 is released, since Bug #48087 should be fixed then.
Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bf799459d8e8eabd764450c82450036c5d0e742f fdo#48087 fill in MsiFileHash table for unversioned files
The two patches from comment 8 and comment 13 solve the original issue, i.e. versioned files have correct file versions in Version column of File table, unversioned files have NULL in Version column of File table and have an entry in MsiFileHash table. Marking as RESOLVED FIXED.