Created attachment 59375 [details] Shows failure to apply features for default language in Hindi etc. Hi, I'm using a modification from GIT pull with Caolán's patch from https://bugs.freedesktop.org/show_bug.cgi?id=31821 With this, a lot of OpenType features are working, that were not working before. However, it may have uncovered a different problem. See the attached file, which compares text in the Indic languages Sinhala and Hindi, from FreeSerif and Lohit Hindi. The Sinhala text in FreeSerif is largely right. This means a lot of font features are being applied (it would be garbled otherwise, with overlapping parts of letters etc). The Hindi text from FreeSerif is wrong. It looks as if no features are being applied. Notice diagonal strokes below the letters, and higher strokes appear beside but disconnected with the letters. Compare this text to the same text in FreeSans and Lohit Hindi -- instead of strokes below, the corresponding letters are transformed, and the higher strokes are placed over the letters. This is my guess as to what is happening. The Sinhala range in FreeSerif, and the Hindi range in Lohit Hindi, are activated by script{language} sinh{dflt} and deva{dflt} respectively. However, in FreeFont a distinction is made between the default language (Hindi) and Sanskrit (both using the Devanagari script). Most features are activated by dev2{SAN ,dflt} deva{SAN ,dflt} However, in FreeSerif only there are some features activated only for Sanskrit by dev2{SAN } deva{SAN } In this text, no language was specified (or rather, it's set to the default of English). So swriter should apply the Devanagari features marked 'dflt'. Instead, it's applying *no* Devanagari features. This is evidently because some features for that script are specified to activate for a specific language. Pango and Firefox get this right.
Forgot to mention: this is using the development version of FreeFont.
Hi Steve, Could you please provide an example of what a correct sample in Firefox looks like as well as the version of FreeFont that you are using. Subscribing caolanm for font-fu
Created attachment 65429 [details] the source LO document showing the problem
Created attachment 65430 [details] HTML file with same text (should work right in FireFox)
Created attachment 65431 [details] Hindi text comparison
Created attachment 65432 [details] Sinhala text comparison
Hi, I now see the PDF was not a good idea. I thought the fonts would be embedded, and some were, but others weren't. I'll replace this with freshly-made images, as well as the original documents. These are made with distro LO 3.5.2. Unfortunately, since the bug was reported, I lost my build with the patch, and I don't know if this LO has the patch I mentioned. It doesn't really matter: as I said, the issue at hand seems to be independent of the patch. Cheers!
Created attachment 65437 [details] how the test doc appears on my system Better illustration of the problem than the previous images.
Created attachment 65535 [details] screenshot from master
Using freefont-otf-20120503 the above is now the screenshot I get with todays master. Looks good to me now.
I concur that your image looks much better -- the egregious errors I was seeing before are gone. I'm still struggling to get the latest pull built, so I can't test it myself... Thanks VERY MUCH for all your work on this!
Created attachment 65545 [details] Some remaining problems in Hindi text
I had Zdenek Wagner look at the latest, and he found a couple of problems remaining in the Hindi text. See attachment. The more serious (in red) is a character replacement that still isn't happening. The other is a spacing issue. This may be a separate bug, I don't know. It will take me some time to sort out what's going on here. Nobody said Indic scripts were going to be easy...
Harshula remarked to me that in your image, the second word in the Sinhala නු seems to be missing a thin vertical line on its right side. (Otherwise he says the text is right.) Is this just an artifact of making the image, or is it in the original rendering of the word?
re comment #14, this vertical line on right side of නු exists on screen. Presumably an artefact of scaling the png or some such
re #13 lets follow up in bug #53584