Created attachment 59591 [details] Mockup The LibreOffice OpenGrok, being a very useful tool, should be more integrated into the website and more visible. Attached is a mockup of what I feel would be better
You can now see a working example at http://and471.github.com/
Basically the things to do are: i Make a link and a page on libreoffice.org which contains the search box code ii Edit the CSS and a bit of code in opengrok which makes the extra chrome on opengrok.libreoffice.org disappear when accessed with ?remote=true iii Edit opengrok to produce better HTML so that the search results part of the mockup can actually be realised (iii is harder as it means editing the source code of opengrok, so it could wait)
Created attachment 60198 [details] Patch for the opengrok branch Here is a patch which adds the "remote" id to the body tag if ?remote=true is present in the URL Also it hides certain things (like the header) with CSS if the 'remote' id is present on the body tag
Created attachment 60199 [details] Correct patch Sorry wrong patch attached earlier, here is the correct one...
Created attachment 60297 [details] Updated patch You meant the following patch?
With this patch applied, tomcat spews this error: java.lang.NullPointerException at org.apache.jsp.search_jsp._jspService(search_jsp.java:456) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190) at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291) at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769) at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698) at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690) at java.lang.Thread.run(Thread.java:736)
Attachment 60199 [details] is the patch generated for the git branch (it adds a remote-attribute.diff patch into the patches folder which is applied with bin/apply-fixes and modifies the CSS file style.css) Does the same error occur with attachment 60199 [details]? On 19/04/2012, bugzilla-daemon@freedesktop.org <bugzilla-daemon@freedesktop.org> wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=48387 > > tbehrens@suse.com changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|UNCONFIRMED |NEW > CC| |tbehrens@suse.com > Ever Confirmed|0 |1 > > --- Comment #6 from tbehrens@suse.com 2012-04-19 01:20:54 PDT --- > With this patch applied, tomcat spews this error: > > java.lang.NullPointerException > at org.apache.jsp.search_jsp._jspService(search_jsp.java:456) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at > org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) > at > org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) > at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190) > at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291) > at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769) > at > org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698) > at > org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891) > at > org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690) > at java.lang.Thread.run(Thread.java:736) > > -- > Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You reported the bug. >
(In reply to comment #7) > Does the same error occur with attachment 60199 [details] [review]? > Yes.
Created attachment 60318 [details] Updated patch Okay this should hopefully work now as it checks if the attribute is non-null before the checks if it is equal to "true"
Created attachment 60331 [details] Patch #2 Another patch :) This (git) patch fixes a bug where if you click on a different search result page, the page doesn't behave remotely (as it doesn't have remote=true in the link). It also adds some padding to the top of the remote page
no update in quite some time, and pending opengrok patch to review :-)
Sorry got exams at the moment so patch will have to wait :/
(In reply to comment #12) > Sorry got exams at the moment so patch will have to wait :/ > Committed the remaining patches to the website repo (from your patch2), did not yet make changes live - Cedric will on the next update. Assigning bug to you, as the guy working on this.
Restricted my LibreOffice hacking area
Setting Assignee back to default. Please assign it back to yourself if you're still working on this issue
Following the breakup, it is possible that your heart is being emptied of all emotion. You want a girl who can pamper you, pamper you, and make you feel valued and appreciated. But on the other side, your heart is weak, and it is challenging to be in a relationship. Your female udaipur escort will do everything perfectly. She will lavish you with all the romantic love and affection you'll never forget. https://www.udaipurescortservice.com https://www.udaipurescortservice.com/call-girls-udaipur-city.html
Female escorts, whether fashionable female escorts or those employed by companies are the prettiest in India. They offer personal and intimate services to their clients, leaving them wanting more. These are among the most romantic, sensual, and naughty female escorts you could ever experience. If you are visiting Dehradun on their first visit, or for novices in service escorts finding a genuine and enjoyable companion can be difficult. That's why we here in the High Profile Girls agency ensure you have an experience you'll always remember. We provide a variety of services for our clients. Our female escorts offer a girl experience and can accommodate more specific needs. With her, you're allowed to express any dream you may have. They do their best to be accommodating and make you feel like an appropriate female escort. https://www.renzy.in/call-girls-in-dehradun.html https://www.renzy.in https://www.renzy.in/dehradun-escort-service.html https://www.renzy.in/mussoorie-escorts-services.html https://www.renzy.in/haridwar-escorts-services.html https://www.renzy.in/dhanaulti-escorts-services.html https://www.renzy.in/rishikesh-escorts-services.html https://www.renzy.in/nainital-escorts-services.html https://www.renzy.in/haldwani-escorts-services.html https://www.renzy.in/bhimtal-escorts-services.html https://www.renzy.in/rudrapur-escorts-services.html https://www.renzy.in/ramnagar-escorts-services.html https://www.renzy.in/lucknow-escorts-services.html
Buovjaga and JJ, wondering if this is still desirable / relevant. The current website has the following links in Improve It > Developers: - Get the code - Talk to developers - Easy hacks - Learn more (wiki) - Development tools (devcentral) -> https://devcentral.libreoffice.org/ - File a bug (Bugzilla) OpenGrok is listed in Devcentral, and I don't think it should be made more prominent than that. Our website needs simplifying, which is what is happening with the new design coming up. Alternatively, add a hyperlink to the "Get the code" section? (e.g. "...or <a>browse it online</a>") Thoughts?
Yes, we should keep things simple.