Bug 49520 - EDITING: CRASH when undo sort with chart
Summary: EDITING: CRASH when undo sort with chart
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other All
: medium major
Assignee: Markus Mohrhard
URL:
Whiteboard: target:6.3.0
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-05-05 00:47 UTC by Rainer Bielefeld Retired
Modified: 2019-12-07 15:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample document (27.08 KB, application/vnd.oasis.opendocument.spreadsheet)
2012-05-05 00:47 UTC, Rainer Bielefeld Retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Bielefeld Retired 2012-05-05 00:47:35 UTC
Created attachment 61067 [details]
sample document

Steps how to reproduce with parallel installation of Master "LOdev 3.6.0alpha0+  – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 35ec153]" (tinderbox: Win-x86@6-fast, pull time 2012-05-02 06:53:41):

1. open attached "sample31.ods"
2. click A3
3. Scroll to end of values using vertical scroll slider
4. <shift+click> C147 to select A3:C147
5. Menu 'Data -> Sort -> Top to bottom - Column B - Ascending' <ok>
   > values sorted, chart view changes
6. Click undo button
   Expected: back to old sort order
   Actual: Crash
7. relaunch LibO 3.6 with recovery
   Expected: complete data
   actual: A3:B147 empty

Crash only happens with Chart, if you do step 2 to 6 after you have deleted char you will get no crash
Comment 1 Julien Nabet 2012-05-05 05:43:27 UTC
On master branch last commit (e10adabc55194cd47f26e726137d2fd036f3cadb) with Pc Debian testing x86-64 (updated today), I don't reproduce this problem.

I just noticed this message on console when I clicked on "Undo" :
warn:legacy.osl:17630:1:/home/julien/compile-libreoffice/libo/svl/source/undo/undo.cxx:427: SfxUndoManager::ImplEnableUndo_NoNotify: not disabled, so why enabling?

(BTW, it could be interesting to consider if the default sorting behaviour shouldn't by a row sorting instead of column sorting, couldn't it)
Comment 2 Markus Mohrhard 2012-05-06 07:00:08 UTC
(In reply to comment #1)
> On master branch last commit (e10adabc55194cd47f26e726137d2fd036f3cadb) with Pc
> Debian testing x86-64 (updated today), I don't reproduce this problem.
> 
> I just noticed this message on console when I clicked on "Undo" :
> warn:legacy.osl:17630:1:/home/julien/compile-libreoffice/libo/svl/source/undo/undo.cxx:427:
> SfxUndoManager::ImplEnableUndo_NoNotify: not disabled, so why enabling?
> 
> (BTW, it could be interesting to consider if the default sorting behaviour
> shouldn't by a row sorting instead of column sorting, couldn't it)

This message is unrelated to this crash.
Comment 3 Rainer Bielefeld Retired 2012-05-06 08:23:55 UTC
@Julien
Sorry, I forgot to mention "Bug 49531 - EDITING: Sort rows for will sort columns", what might be part of the problem
Comment 4 Markus Mohrhard 2012-05-06 16:44:20 UTC
This one looks like a broadcaster lifetime problem.
Comment 5 Markus Mohrhard 2012-05-06 18:00:04 UTC
After thinking a bit this one is most likely related to my note storage rework. I must have missed one place where we now have to copy broadcasters and therefore we are using a deleted broadcaster.
Broadcasters for cells have been stored in ScNoteCells which are now more or less unused. I will need to think a bit about this one. There must been an non obvious case that I missed.
Comment 6 Markus Mohrhard 2012-08-28 16:46:58 UTC
I think it is now fixed with my bug fix for Bug 54074.

THe problem was a double delete of a broadcaster. Please test with 3.6.2 and check that it is really fixed and otherwise reopen.
Comment 7 Commit Notification 2018-12-31 15:36:01 UTC
Zdeněk Crhonek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b22d08827c0d42890cf1e45d084dc3e08bc48aa9%5E%21

uitest for bug tdf#49531 tdf#49520

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 raal 2019-12-07 15:22:22 UTC
The test exist, set status to Verified.